Bug 512016 (zikula-module-Polls) - Review Request: zikula-module-Polls - Simple voting system for Zikula
Summary: Review Request: zikula-module-Polls - Simple voting system for Zikula
Keywords:
Status: CLOSED ERRATA
Alias: zikula-module-Polls
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nick Bebout
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 508379
TreeView+ depends on / blocked
 
Reported: 2009-07-15 22:49 UTC by eric
Modified: 2009-11-18 20:21 UTC (History)
4 users (show)

Fixed In Version: 2.0.2-3.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-27 06:51:05 UTC
Type: ---
nb: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Ian Weller 2009-07-17 16:54:47 UTC
reviewing this

Comment 2 Ian Weller 2009-07-17 17:02:40 UTC
fix:

- typo in URL tag
- can you show me where it says GPL in the source?

Comment 3 eric 2009-07-23 12:43:27 UTC
Spec URL:
http://sparks.fedorapeople.org/Packages/zikula-module-Polls/zikula-module-Polls.spec

SRPM URL:
http://sparks.fedorapeople.org/Packages/zikula-module-Polls/zikula-module-Polls-2.0.2-3.fc11.src.rpm

[TKCTECH\eric.christensen@echristensen modules]$ grep -ri license ./*
./Polls/pnjavascript/polls.js: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnuser.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/deu/common.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/deu/poll.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/deu/admin.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/deu/version.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/deu/init.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/deu/user.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/eng/common.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/eng/poll.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/eng/admin.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/eng/version.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/eng/init.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/eng/user.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/common.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/common.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/poll.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/poll.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/admin.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/admin.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/version.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/version.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/init.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/init.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/user.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnlang/spa/user.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnuserapi.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pninit.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnblocks/poll.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pntables.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnajax.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnversion.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnversion.php:$modversion['license'] = 'pndocs/license.txt';
./Polls/pnadmin.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html
./Polls/pnadminapi.php: * @license GNU/GPL - http://www.gnu.org/copyleft/gpl.html

Comment 4 eric 2009-10-19 14:20:05 UTC
PING

Comment 5 Nick Bebout 2009-10-19 22:45:43 UTC
I'll review this, per discussion on IRC.

Comment 6 Nick Bebout 2009-10-19 23:15:15 UTC
rpmlint is clean.

[nb@epsilon SPECS]$ rpmlint zikula-module-Polls.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[nb@epsilon SRPMS]$ rpmlint zikula-module-Polls-2.0.2-3.fc12.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[nb@epsilon noarch]$ rpmlint zikula-module-Polls-2.0.2-3.fc12.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Sources match.  
License is correct.

Package appears to follow rest of packaging guidelines

APPROVED.

Comment 7 eric 2009-10-20 00:03:34 UTC
New Package CVS Request
=======================
Package Name: zikula-module-Polls
Short Description: Simple voting system for Zikula
Owners: sparks ke4qqq
Branches: F-12 F-11 EL-5
InitialCC:

Comment 8 Kevin Fenzi 2009-10-22 04:34:34 UTC
cvs done.

Comment 9 Fedora Update System 2009-10-22 23:33:50 UTC
zikula-module-Polls-2.0.2-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/zikula-module-Polls-2.0.2-3.el5

Comment 10 Fedora Update System 2009-10-22 23:58:31 UTC
zikula-module-Polls-2.0.2-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/zikula-module-Polls-2.0.2-3.fc11

Comment 11 Fedora Update System 2009-10-23 23:19:33 UTC
zikula-module-Polls-2.0.2-3.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update zikula-module-Polls'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0715

Comment 12 Fedora Update System 2009-10-27 06:50:59 UTC
zikula-module-Polls-2.0.2-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2009-11-18 20:20:58 UTC
zikula-module-Polls-2.0.2-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.