=Comment: #0================================================= Emily J. Ratliff <ratliff.com> - 1. Feature Overview: Feature Id: [201916] a. Name of Feature: Update ibmvscsi driver with upstream multipath enhancements b. Feature Description Update the ibmvscsi driver with support for client issued reservations and for fastfail mode, for improved multipathing support. Also update command timeouts to more reasonable values to fix command timeout problems we have seen in test. Fix other miscellaneous issues with the ibmvscsi driver. 2. Feature Details: Sponsor: PPC - P Architectures: ppc64 Arch Specificity: Purely Arch Specific Code Affects Kernel Modules: Yes Delivery Mechanism: Backport Category: Power Virtualization Request Type: Driver - Feature from Upstream d. Upstream Acceptance: Accepted Sponsor Priority 2 f. Severity: Medium IBM Confidential: no Code Contribution: IBM code g. Component Version Target: 2.6.31 3. Business Case Lack of support for reservations has hindered support of third party clustering applications. Additionally, lack of fastfail support in the Linux client increases path failure detection time significantly. This feature closes both of these gaps and makes multipath support in the ibmvscsi driver more robust. 4. Primary contact at Red Hat: John Jarvis jjarvis 5. Primary contacts at Partner: Project Management Contact: Mike Wortman, wortman.com Technical contact(s): Brian King, bjking1.com Robert Jennings, rcjenn.com IBM Manager: Alexander Johnson, acjohnso.com
IBM is signed up to test and provide feedback.
Created attachment 360510 [details] IBMvSCSI backports for RHEL55 ------- Comment on attachment From rcj.ibm.com 2009-09-10 10:26 EDT------- This patch combines the following six upstream patches to be backported to RHEL55. This patch was based on the RHEL54 2.6.18-164.el5 source tree. -- e08afeb [SCSI] ibmvscsi: Fix module load hang -- Brian King [Tue, 23 Jun 2009] Fixes a regression seen in the ibmvscsi driver when using the VSCSI server in SLES 9 and SLES 10. The VSCSI server in these releases has a bug in it in which it does not send responses to unknown MADs. Check the OS Type field in the adapter info response and do not send these unsupported commands when talking to an older server. -- 126c5cc [SCSI] ibmvscsi: Add support for capabilities MAD -- Brian King [Mon, 8 Jun 2009] Add support to ibmvscsi for the capabilities MAD. This command gets sent to the Virtual I/O server prior to login in order to communicate client capabilities. Additionally it returns information regarding capabilities that the server supports. The two main capabilities communicated in this MAD are related to partition migration and client reserve. Client reserve allows for SCSI-2 reservations to be sent to virtual disks which are backed by physical LUNs and will result in the reservation being sent to the physical LUN. -- c1988e3 [SCSI] ibmvscsi: Enable fast fail feature -- Robert Jennings [Mon, 8 Jun 2009] A new mode of error reporting, fast fail, has been added to the VIOS which allows failover to happen more quickly. If this new fast fail mode is enabled on the VIOS and the vSCSI client supports the mode, the VIOS will not return MEDIUM error on path failures, but rather return VIOSRP_ADAPTER_FAIL in the crq response, which ibmvscsi will translate to DID_ERROR. This new mode can be enabled for single path configurations as well, so it is the new default error reporting mode. A module parameter is provided to disable this new behavior on the off chance it causes a problem on some old VIOS version. -- 3507e13 [SCSI] ibmvscsi: Send adapter info before login -- Brian King [Mon, 8 Jun 2009] The ibmvscsi driver currently sends the SRP Login before sending the Adapter Info MAD, which can result in commands getting sent to the virtual adapter before we are ready for them. This results in a slight window where the target devices may not behave as expected. Change the order and close the window. -- 16b3858 [SCSI] ibmvscsi: Remove redundant test on unsigned. -- Roel Kluin [Sat, 2 May 2009] -- e637d55 [SCSI] ibmvscsi: Correct DMA mapping leak -- Robert Jennings [Thu, 22 Jan 2009] The ibmvscsi client driver is not unmapping the SCSI command after encountering a DMA mapping error while trying to map an indirect scattergather list for the event pool.
This enhancement request was evaluated by the full Red Hat Enterprise Linux team for inclusion in a Red Hat Enterprise Linux minor release. As a result of this evaluation, Red Hat has tentatively approved inclusion of this feature in the next Red Hat Enterprise Linux Update minor release. While it is a goal to include this enhancement in the next minor release of Red Hat Enterprise Linux, the enhancement is not yet committed for inclusion in the next minor release pending the next phase of actual code integration and successful Red Hat and partner testing.
Created attachment 369806 [details] rework patch to resolve spacing issues reported by checkpatch.pl rework patch to resolve spacing issues reported by checkpatch.pl
in kernel-2.6.18-182.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please update the appropriate value in the Verified field (cf_verified) to indicate this fix has been successfully verified. Include a comment with verification details.
------- Comment From brking.com 2010-02-10 10:41 EDT------- Verified the patch is included in RHEL 5.5 Beta.
------- Comment From brking.com 2010-02-15 18:44 EDT------- Verified in RHEL 5.5 Beta. Verified that both fastfail and client reserve got enabled. Enabled client reserve on a virtual scsi disk and was able to reserve the LUN via one VIOS using SCSI-2 reservations and saw the reservation conflict when accessing via the second VIOS. Additionaly, installed to a multipath VSCSI configuration with no issues and ran LTP disktest with error checking with no issues.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0178.html