Bug 512272 - Review Request: surl - A URL shortening command line tool
Summary: Review Request: surl - A URL shortening command line tool
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Susi Lehtola
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-16 22:53 UTC by Fabian Affolter
Modified: 2009-08-05 00:37 UTC (History)
4 users (show)

Fixed In Version: 0.5.4-1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-05 00:37:58 UTC
Type: ---
Embargoed:
susi.lehtola: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Fabian Affolter 2009-07-16 22:53:42 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/surl.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/surl-0.5.1-1.fc11.src.rpm

Project URL: https://launchpad.net/surl

Description:
surl is a URL shortening command line application that supports
various sites. It supports stdin or filename input. It grabs the
URLs, converts them, and returns the same text that was used in
the input. It is known to work with a wealth of services, such as
bit.ly, tinyurl.com and tr.im.

The currently supported sites are a.gd, bit.ly, burnurl.com, cli.gs,
decenturl.com, digg.com, is.gd, kl.am, liip.to, metamark.net, sn.im,
snipr.com, snipurl.com, snurl.com, tinyurl.com, tr.im, turl.ca, ur.ly,
and zz.gd.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1480612

rpmlint output:
[fab@laptop09 SRPMS]$ rpmlint surl-0.5.1-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop09 noarch]$ rpmlint surl-0.5.1-1.fc11.noarch.rpm 
surl.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/surl/surl.py 0644
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

This should not be a problem because surl.py is called by /bin/surl.

Comment 1 Susi Lehtola 2009-07-17 11:27:14 UTC
You can get rid of the rpmlint error by removing the shebang from the library file.

Comment 2 Fabian Affolter 2009-07-17 12:04:47 UTC
For me this is not working because this ends with an error:

/usr/bin/surl: Zeile 1:  surl - a URL shortening application, supports various sites : Kommando nicht gefunden.

After the changing of the permission, rpm added as requirement '/bin/python'

Comment 3 Susi Lehtola 2009-07-17 12:22:41 UTC
(In reply to comment #2)
> For me this is not working because this ends with an error:
> 
> /usr/bin/surl: Zeile 1:  surl - a URL shortening application, supports various
> sites : Kommando nicht gefunden.
> 
> After the changing of the permission, rpm added as requirement '/bin/python'  

Python libraries are not supposed to be executable.

After install just execute
sed -i -e '/^#!\//, 1d' %{buildroot}%{python_sitelib}/%{name}/surl.py

Comment 4 Fabian Affolter 2009-07-17 12:40:02 UTC
I placed the stuff in the wrong section.  Thanks for your help, Jussi.

Updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/surl.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/surl-0.5.1-2.fc11.src.rpm

Comment 5 Susi Lehtola 2009-07-17 12:50:53 UTC
rpmlint output is clean.


MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK
MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the  Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. N/A
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A

MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSWORK
- Add PKG-INFO.

MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

Fix the spec before importing to CVS. The package has been

APPROVED.

Comment 6 Fabian Affolter 2009-07-17 13:11:36 UTC
Thanks for the review.

Comment 7 Fabian Affolter 2009-07-17 13:12:12 UTC
New Package CVS Request
=======================
Package Name: surl
Short Description: A URL shortening command line tool
Owners: fab
Branches: F-10 F-11
InitialCC:

Comment 8 Jason Tibbitts 2009-07-17 15:48:57 UTC
CVS done.

Comment 9 Savvas Radevic 2009-07-23 14:54:35 UTC
Thank you for the tip as well :)

Comment 10 Fedora Update System 2009-07-28 17:30:11 UTC
surl-0.5.4-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/surl-0.5.4-1.fc11

Comment 11 Fedora Update System 2009-07-29 21:28:01 UTC
surl-0.5.4-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update surl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8077

Comment 12 Fedora Update System 2009-08-05 00:37:53 UTC
surl-0.5.4-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.