Bug 512639 - Review Request: ibus-table-translit - Translit table for IBus Table.
Summary: Review Request: ibus-table-translit - Translit table for IBus Table.
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-20 05:49 UTC by Caius Chance
Modified: 2009-08-07 04:38 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-07 04:38:55 UTC
Type: ---
Embargoed:
panemade: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Parag AN(पराग) 2009-07-21 06:47:12 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1488960
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fa34ab48dc174452c4d667ac9384d39727497190  ibus-table-translit-1.2.0.20090720.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestion:
1) use configure instead autogen.sh
2)you already requires ibus-table then what is need to own 
%dir %{_datadir}/ibus-table
%dir %{_datadir}/ibus-table/icons
%dir %{_datadir}/ibus-table/tables
3)drop
BuildRequires:    gettext-devel >= 0.17, automake >= 1.10

Comment 3 Parag AN(पराग) 2009-07-23 05:50:01 UTC
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1493946
APPROVED.

Comment 4 Caius Chance 2009-07-24 00:01:30 UTC
New Package CVS Request
=======================
Package Name: ibus-table-translit
Short Description: Translit table of IBus Table
Owners: cchance
Branches: F-11 EL-6
InitialCC: i18n-team

Comment 5 Jason Tibbitts 2009-07-24 19:17:57 UTC
CVS done.

Comment 6 Caius Chance 2009-08-07 04:38:55 UTC
built on rawhide


Note You need to log in before you can comment on or make changes to this bug.