Spec URL: http://kwizart.fedorapeople.org/review/perl-Socket-GetAddrInfo.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Socket-GetAddrInfo-0.12-1.fc11.src.rpm Description: RFC 2553's "getaddrinfo" and "getnameinfo" functions
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1489181 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 149d3ea0db5cdd3323735a170e800f318a9396e8 Socket-GetAddrInfo-0.12.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=47, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.14 cusr 0.03 csys = 0.22 CPU) + Package perl-Socket-GetAddrInfo-0.12-1.fc12.i686=> Provides: GetAddrInfo.so perl(Socket::GetAddrInfo) = 0.12 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) perl(Carp) perl(DynaLoader) perl(Exporter) perl(Scalar::Util) perl(strict) perl(warnings) rtld(GNU_HASH) + Not a GUI application Suggestions: 1) Use %{perl_vendorarch}/Socket %{perl_vendorarch}/auto/Socket in %files APPROVED.
Thx for the review, I will adopt the suggested %file section.
New Package CVS Request ======================= Package Name: perl-Socket-GetAddrInfo Short Description: RFC 2553's "getaddrinfo" and "getnameinfo" functions Owners: kwizart Branches: F-11 F-10 EL-5 InitialCC: perl-sig
CVS done.