Spec URL: http://kwizart.fedorapeople.org/review/perl-Devel-Refcount.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Devel-Refcount-0.06-1.fc11.src.rpm Description: Obtain the REFCNT value of a referent
2 remarks: * ... %{perl_vendorarch}/* %exclude %dir %{perl_vendorarch}/auto/ I for one find using %{perl_vendorarch}/Devel %{perl_vendorarch}/auto/Devel much more readable and less error-prone * Nicolas, are you familiar with cpanspec? Me thinks, you might be one of the very few persons who are still manually writing perl-specs from scratch.
Taking.
(In reply to comment #1) > 2 remarks: > > * ... > %{perl_vendorarch}/* > %exclude %dir %{perl_vendorarch}/auto/ > > I for one find using > %{perl_vendorarch}/Devel > %{perl_vendorarch}/auto/Devel > much more readable and less error-prone It makes sense to me, I will adopt this new scheme. > * Nicolas, are you familiar with cpanspec? > Me thinks, you might be one of the very few persons who are still manually > writing perl-specs from scratch. I wasn't using cpanspec until now, but it showed some interesting differences that I've missed, over rpmdev-newspec using perl default template. (ex Module::Build specifics) I will convert the spec with cpanspec...
I've moved to cpanspec without bumping release. ^ Spec URL: http://kwizart.fedorapeople.org/review/perl-Devel-Refcount.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Devel-Refcount-0.06-1.fc11.src.rpm Description: Obtain the REFCNT value of a referent
Sorry, it took so long, Nicolas. Getting koji to complete a scratch build was impossible for a few days. Review: + package builds in mock (f12). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1562366 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 97398b8091432ebe16528d13d1169233 Devel-Refcount-0.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=28, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.14 cusr 0.02 csys = 0.20 CPU) Result: PASS + Package perl-Devel-Refcount-0.06-1.fc12.i686 => Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 libc.so.6 libc.so.6(GLIBC_2.1.3) perl(base) perl(strict) perl(warnings) rtld(GNU_HASH) Provides: Refcount.so perl(Devel::Refcount) = 0.06 Nitpick: I find %{perl_vendorarch}/auto/Devel* %{perl_vendorarch}/Devel* to be more readable than %{perl_vendorarch}/auto/* %{perl_vendorarch}/Devel* APPROVED.
Thx for the review ! New Package CVS Request ======================= Package Name: perl-Devel-Refcount Short Description: Obtain the REFCNT value of a referent Owners: kwizart Branches: F-11 F-10 EL-5 InitialCC: perl-sig
CVS done.
You set the CVS flag back to '?'; what did you need?
Sorry, that was a misstake. Thx for the CVS creation Tibbs