Created attachment 354590 [details]
Patch to allow showing saved searches in users front page (v1)

New patch that adds ability for a user to select certain saved searches for displaying on frontpage.cgi. This allows some customization of the front page.

To accomplish this I did quite a bit of restructuring in frontpage.cgi and the related templates. I also had to add a new 'namedqueries_in_front_page' table that maps the queries similar to 'namedqueries_link_in_footer' and update Bugzilla/Search/Saved.pm.

Big patch, please review if you get time.
Dave

Hi Dave,

I have looked at the patch and tested it a bit. It is perfect and working very nicely with me so far. Just one thing i noticed , is that in the frontpage.cgi if you click on the top link on one of the save searches names it takes you down to the table but the saved search name itself is now showing from the scrolling down, I guess just an anchor issue  that need to be changed to point to search name i guess. 

Also do you think maybe it is better to have the saved searched right at the end of the frontpage.cgi instead of having it between the bugs and the flags sections? just as it comes at the end of the links at the top of the frontpage, Just a thought but maybe you have a better reason for having it where it is now :). 

Other than that Good Work Dave ;) , I really like that idea.

Thanks,
Noura

Thanks for the review Noura. 

(In reply to comment #2)
> Hi Dave,
> 
> I have looked at the patch and tested it a bit. It is perfect and working very
> nicely with me so far. Just one thing i noticed , is that in the frontpage.cgi
> if you click on the top link on one of the save searches names it takes you
> down to the table but the saved search name itself is now showing from the
> scrolling down, I guess just an anchor issue  that need to be changed to point
> to search name i guess. 

Yeah there was a conflict with the <div> id's having the same name as the anchor names. So I was able to fix that.

> Also do you think maybe it is better to have the saved searched right at the
> end of the frontpage.cgi instead of having it between the bugs and the flags
> sections? just as it comes at the end of the links at the top of the frontpage,
> Just a thought but maybe you have a better reason for having it where it is now
> :). 
> 

The way the code is setup is it addes the saved search results to the standard search results in an array of hashes. So the template just loops through the results array and executes the same template code over and over.

To be able to split the two sections up to match the menu at the top I will need to move the generic template code to a BLOCK and then I can call it whereever I need to. I will file a separate bug about that.

Until then I dont think people will be too confused the way it is.

On another subject, the patch I checked in is different than the one you reviewed in that I further simplified it as I had a lot of duplicate code in the script. I put the query definitions in a data structure that I could just loop through now so the code is not duplicated. But otherwise the rest is the same.

Dave