Bug 513191 - Review Request: php-facedetect - PHP extension to access the OpenCV library
Summary: Review Request: php-facedetect - PHP extension to access the OpenCV library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-22 13:28 UTC by Andrew Colin Kissa
Modified: 2009-09-12 17:51 UTC (History)
2 users (show)

Fixed In Version: 1.0.0-2.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-17 21:57:24 UTC
Type: ---
Embargoed:
j: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Andrew Colin Kissa 2009-07-22 13:28:30 UTC
Spec URL: http://topdog-software.com/oss/SRPMS/fedora/php-facedetect/php-facedetect.spec
SRPM URL: http://topdog-software.com/oss/SRPMS/fedora/php-facedetect/php-facedetect-1.0.0-1.fc11.src.rpm
Description:
This extension provides a PHP implementation of the OpenCV library.
The extension offers two new functions. In principle, they differ
only by their return value. The first returns only the number of
faces found on the given image and the other an associative array
of their coordinates.

Comment 1 Jason Tibbitts 2009-07-29 22:47:16 UTC
Builds fine and rpmlint is silent.  This is not a PECL package, so the naming is correct.

Your macro usage is not correct; use either %{buildroot} or $RPM_BUILD_ROOT as you wish, but don't use both.

That's the only issue I see, and it's minor, so I'll go ahead and approve this and you can go ahead and fix up the spec when you import the package.

* source files match upstream.  sha256sum:                   
   a0173c785c29bbebdd82f223a27c6682cec4791920c9cabc3ca6f5fd174eb8b0
   facedetect-1.0.0.tar.gz
* package meets naming and versioning guidelines.
X specfile does not use macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   config(php-facedetect) = 1.0.0-1.fc12
   facedetect.so()(64bit)
   php-facedetect = 1.0.0-1.fc12
   php-facedetect(x86-64) = 1.0.0-1.fc12
  =
   config(php-facedetect) = 1.0.0-1.fc12
   libcv.so.2()(64bit)
   libcvaux.so.2()(64bit)
   libcxcore.so.2()(64bit)
   libhighgui.so.2()(64bit)
   php(api) = 20090626
   php(zend-abi) = 20090626

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

Comment 2 Andrew Colin Kissa 2009-07-30 08:10:01 UTC
Thanks Jason, for the review.

New Package CVS Request
=======================
Package Name: php-facedetect
Short Description: PHP extension to access the OpenCV library
Owners: topdog
Branches: F-10 F-11 EL-5

Comment 3 Jason Tibbitts 2009-07-30 22:53:35 UTC
CVS done.

Comment 4 Fedora Update System 2009-07-31 16:14:22 UTC
php-facedetect-1.0.0-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/php-facedetect-1.0.0-2.fc11

Comment 5 Fedora Update System 2009-07-31 16:14:27 UTC
php-facedetect-1.0.0-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/php-facedetect-1.0.0-2.fc10

Comment 6 Fedora Update System 2009-08-01 23:58:51 UTC
php-facedetect-1.0.0-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-facedetect'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8202

Comment 7 Fedora Update System 2009-08-02 00:01:56 UTC
php-facedetect-1.0.0-2.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-facedetect'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8214

Comment 8 Fedora Update System 2009-08-17 21:57:18 UTC
php-facedetect-1.0.0-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2009-08-17 21:58:04 UTC
php-facedetect-1.0.0-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-08-26 16:44:55 UTC
php-facedetect-1.0.0-2.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/php-facedetect-1.0.0-2.el5

Comment 11 Fedora Update System 2009-09-12 17:51:14 UTC
php-facedetect-1.0.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.