Bug 513497 - Review Request: ovirt-viewer - A vnc viewer for oVirt managed vms
Summary: Review Request: ovirt-viewer - A vnc viewer for oVirt managed vms
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-23 22:07 UTC by Mo Morsi
Modified: 2010-01-05 16:50 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-01-05 16:50:33 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mo Morsi 2009-07-23 22:07:43 UTC
Spec URL: http://mohammed.morsi.org/blog/files/ovirt-viewer.spec
SRPM URL: http://mohammed.morsi.org/blog/files/ovirt-viewer-1.0.0-5.fc10.src_.rpm

Description: 
ovirt-viewer is a vnc viewer which integrates nicely into the ovirt
framework. When running the program, the user is prompted for the 
ovirt server url and login credentials, after which a list of
accessible vms is retrieved, any of which the user may connect
to via vnc. ovirt-viewer manages all connections on the backend and 
allows the users to seamlessly switch between managed vms via ui.

Latest Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1496325

This is intended to be used in conjunction with https://bugzilla.redhat.com/show_bug.cgi?id=513069

Comment 1 Fabian Affolter 2009-07-24 15:19:56 UTC
Just some comments after a quick look at your spec file:

- You are mixing '%{buildroot}' and '$RPM_BUILD_ROOT'
  https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
  Please take a look at https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

- The man pages are automatically compressed by RPM

- README and COPYING must be added to the %files section.
  https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_prefixes

- Isn't %configure instead of ./configure working?
  https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25build_section

- Aren't gtk2, gtk-vnc, and gnutls automatically picked up by RPM?

Comment 2 Fabian Affolter 2009-12-23 12:39:35 UTC
ping?

Comment 3 Mo Morsi 2010-01-05 16:50:33 UTC
Sorry for the belated followup. Priorities shifted and didn't/don't have time to work on this, thus am closing. If anyone wants to resume work on the viewer itself or packaging it for Fedora, feel free to ping me w/ any questions you may have.


Note You need to log in before you can comment on or make changes to this bug.