Bug 513543 - Review Request: znc-extra - Extra modules for ZNC IRC bouncer
Summary: Review Request: znc-extra - Extra modules for ZNC IRC bouncer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jon Stanley
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-24 05:07 UTC by Nick Bebout
Modified: 2009-08-07 05:05 UTC (History)
3 users (show)

Fixed In Version: 0.074-1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-07 05:02:48 UTC
Type: ---
Embargoed:
jonstanley: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Nick Bebout 2009-07-24 05:07:56 UTC
Spec URL: http://nb.fedorapeople.org/znc-extra.spec
SRPM URL: http://nb.fedorapeople.org/znc-extra-0.074-1.fc11.src.rpm
Description: Extra modules for ZNC IRC bouncer

0.074 of ZNC is not pushed to stable yet (I just submitted it tonight), you will either have to grab it from koji or wait for it to be pushed, this package Requires: znc = %{version} and BuildRequires: znc-devel = %{version}

Source is not available at the URL in the spec, because the znc-extra source is still named 0.072, no changes were made to the znc-extra source for 0.074, but it is necessary to have the versions the same because the modules have to be compiled against the version of ZNC that they are to work with.

[nb@nb-desktop SPECS]$ rpmlint znc-extra.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[nb@nb-desktop SRPMS]$ rpmlint znc-extra-0.074-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[nb@nb-desktop i586]$ rpmlint znc-extra-0.074-1.fc11.i586.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[nb@nb-desktop i586]$ rpmlint znc-extra-debuginfo-0.074-1.fc11.i586.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jon Stanley 2009-08-03 04:20:01 UTC
Some problems:

 * Fix the version to match upstream, and require the explicit version
 * This package owns /usr/lib64/znc, yet Requires znc, which also provides that (as well as /usr/share/znc, /usr/share/znc/webadmin, and /usr/share/znc/webadmin/skins).  See https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
 * Include blank lines between changelog entries

Comment 2 Nick Bebout 2009-08-03 04:35:07 UTC
SPEC: http://nb.fedorapeople.org/znc-extra.spec
SRPM: http://nb.fedorapeople.org/znc-extra-0.072-2.fc11.src.rpm

I believe this fixes the problems.

Comment 3 Nick Bebout 2009-08-03 05:02:39 UTC
SPEC: http://nb.fedorapeople.org/znc-extra.spec
SRPM: http://nb.fedorapeople.org/znc-extra-0.072-3.fc11.src.rpm

This re-adds BuildRequires: openssl-devel >= 0.9.8 as noted on IRC.

Comment 4 Jon Stanley 2009-08-04 01:24:23 UTC
Soruces match upstream:
[jds2001@rugrat znc-extras]$ sha1sum znc-upstream.tar.gz new/znc-extra-0.072.tar.gz 
14136cdff5df809301fd0db6daabd9c74a4e0c4c  znc-upstream.tar.gz
14136cdff5df809301fd0db6daabd9c74a4e0c4c  new/znc-extra-0.072.tar.gz

rpmlint clean:
[jds2001@rugrat result]$ rpmlint *.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Provides and requires are sane.

Package doesn't own any directories belonging to other packages.

debuginfo generated

APPROVED

Comment 5 Nick Bebout 2009-08-04 04:10:45 UTC
New Package CVS Request
=======================
Package Name:  znc-extra
Short Description: Extra modules for ZNC - an IRC bouncer
Owners: nb
Branches: F-10 F-11 EL-4 EL-5
InitialCC: nb

Comment 6 Jason Tibbitts 2009-08-04 20:27:05 UTC
CVS done.

Comment 7 Fedora Update System 2009-08-05 04:50:43 UTC
znc-extra-0.074-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/znc-extra-0.074-1.fc10

Comment 8 Fedora Update System 2009-08-05 04:50:48 UTC
znc-extra-0.074-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/znc-extra-0.074-1.fc11

Comment 9 Fedora Update System 2009-08-07 05:02:43 UTC
znc-extra-0.074-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-08-07 05:05:21 UTC
znc-extra-0.074-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.