Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy-0.0.2-1.fc11.src.rpm Project URL: https://sourceforge.net/projects/pyfuzzy/ Description: pyfuzzy is a framework to work with fuzzy sets and process them with operations of fuzzy logic. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1513784 rpmlint output: [fab@laptop09 SRPMS]$ rpmlint pyfuzzy-0.0.2-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [fab@laptop09 noarch]$ rpmlint pyfuzzy-0.0.2-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
After a briew review I wanted to point out that the license is GPL, not GPL+ ... but ... you are right, GPL is GPL+. Sligtly annoying that the rpm with the name pyfuzzy and with a pyfuzzy egg occupies the name fuzzy from the namespace. IMHO python-fuzzy would have been more appropriate, but who cares ... nuff said
Well, the name is correct according to the guidelines. The upstream project is 'pyfuzzy', the tarball is 'pyfuzy', and it has 'py' in the name so no 'python-' prefix is necessary. 'python-fuzzy', on the other hand, would be against the guidelines. Perl at least has this handled with the 'perl(Foo::Bar)' automatic dependencies. Also, GPL and GPL+ are not the same thing, as the author could choose not to use the "any later version" option. Of course, they didn't actually specify anything but "GPL" in one place, but Fabian has already requested that upstream fix that up so in the meantime we assume GPL+. Of course, upstream seems to be completely idle for the past six years, so... There's a test suite. You can call the individual tests with: %check cd test export PYTHONPATH=%{buildroot}/%{python_sitelib} ./test_defuzzyfication.py ./test_merge.py ./test_norm.py ./test_set.py (or you could use a loop or something). However, only test_defuzzyfication seems to work. It looks like there may be an issue with outdated python syntax. Could you double-check? If the module has issues with python 2.6 then it would be better to know that up front instead of after it gets imported and built. * source files match upstream. sha256sum: c3cc76ad5283e38b540db29b1cb56fff671fbe0d94a2808fa219896833f5a417 pyfuzzy-0.0.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: pyfuzzy = 0.0.2-1.fc12 = gnuplot python(abi) = 2.6 ? %check is not present, but there seem to be some tests. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
I reported all issues upstream. It's right that there was no release in the last 6 years but there was some action in the VCS in January. All issues are reported upstream.
http://sourceforge.net/tracker/?group_id=59160&atid=490101
According to upstream a new release will come out soon.
Any update?
The guy from upstream is still working on a new release.
Hi, I am always working on new releases, but you might have missed the last one from 2009-10-18, see https://sourceforge.net/projects/pyfuzzy/files/.
Hmmm, I missed that. I will provide a new package soon.
Here are the updated files Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy-0.1.0-1.fc11.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1820590
I seem to have let this fall through the cracks, sorry about that. The current version builds fine and rpmlint is silent. The license of the code seems to be LGPLv3+. LICENSE.txt has the LGPLv3 text, and the source files all seem to have the proper LGPLv3 license block with the "any later version" text, and setup.py says "LGPL". Did I miss something? I don't see any mention of the test suite in your comments, but the test files seem to have disappeared in the latest source so I suppose that's OK.
(In reply to comment #11) > The license of the code seems to be LGPLv3+. LICENSE.txt has the LGPLv3 text, > and the source files all seem to have the proper LGPLv3 license block with the > "any later version" text, and setup.py says "LGPL". Did I miss something? The license is LGPLv3+ > I don't see any mention of the test suite in your comments, but the test files > seem to have disappeared in the latest source so I suppose that's OK. Starting with 0.1.0 the test suite is no longer included. Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy-0.1.0-2.fc12.src.rpm
Looks good, thanks. APPROVED
New Package SCM Request ======================= Package Name: pyfuzzy Short Description: Python framework for fuzzy sets Owners: fab Branches: F-14 F-13 InitialCC:
Git done (by process-git-requests).
Is there any reason why this ticket is still open?
No