Bug 514025 - 'xm pci-list' fails on PV guest
Summary: 'xm pci-list' fails on PV guest
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: xen
Version: 5.4
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Don Dugger
QA Contact: Virtualization Bugs
URL:
Whiteboard:
: 544947 (view as bug list)
Depends On: 507257
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-27 17:06 UTC by Don Dugger
Modified: 2014-07-25 03:22 UTC (History)
11 users (show)

Fixed In Version: xen-3.0.3-99.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 08:58:49 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
fix the format string 'has_vslt' for pv guest (478 bytes, patch)
2009-07-27 17:11 UTC, Don Dugger
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2010:0294 0 normal SHIPPED_LIVE xen bug fix and enhancement update 2010-03-29 14:20:32 UTC

Description Don Dugger 2009-07-27 17:06:23 UTC
Description of problem:

When doing `xm pci-list' on a PV guest you get the failurs:

Unexpected error: exceptions.TypeError

Please report to xen-devel.com
Traceback (most recent call last):
  File "/usr/sbin/xm", line 10, in ?
    main.main(sys.argv)
  File "/usr/lib64/python2.4/site-packages/xen/xm/main.py", line 1595, in main
    rc = cmd(args)
  File "/usr/lib64/python2.4/site-packages/xen/xm/main.py", line 1267, in
xm_pci_list
    print ( fmt_str % x )
TypeError: int argument required

Version-Release number of selected component (if applicable):
  RHEL 5.4 Snap 2

Comment 1 Don Dugger 2009-07-27 17:11:33 UTC
Created attachment 355298 [details]
 fix the format string 'has_vslt' for pv guest  

PV guest has no 'vslot' and here the wrong fmt_str is chosen.  This patch fixes the problem by checking for this situation.

Comment 2 Dexuan Cui 2009-07-28 02:43:06 UTC
Xudong, can you check if the latest RHEL5.4 build (what's the version?) has or hasn't the bug? Thanks!

Comment 3 Hao, Xudong 2009-07-28 02:57:32 UTC
Latest RHEL5.4 Snap3 has this bug.

Comment 4 Don Dugger 2009-07-28 03:42:01 UTC
I've made a brew build with this patch included, it's available at:

  http://brewweb.devel.redhat.com/brew/taskinfo?taskID=1907424

Can you test and verify, preferrably for PV and HVM guests, that this build fixes the problem?

Comment 5 Dexuan Cui 2009-07-28 04:09:51 UTC
(In reply to comment #4)
> I've made a brew build with this patch included, it's available at:
>   http://brewweb.devel.redhat.com/brew/taskinfo?taskID=1907424
> Can you test and verify, preferrably for PV and HVM guests, that this build
> fixes the problem?  

Xudong, can you help to test the new binary as Don asked? Thanks!

Don, BTW, looks we can't open the link from Shanghai: my browser tells me:

_______________________________________________________
Network Error (dns_server_failure) 
 
Your request could not be processed because an error occurred contacting the DNS server.  
The DNS server may be temporarily unavailable, or there could be a network problem.  

For assistance, contact your network support team.  
-------------------------------------------------------

Comment 6 Don Dugger 2009-07-28 05:10:42 UTC
Sigh, my mistake, that URL is not publicly addressable.  NP, I'll send you the RPMs via normal email, expect them soon.

Comment 7 Hao, Xudong 2009-07-28 06:27:30 UTC
(In reply to comment #4)
> I've made a brew build with this patch included, it's available at:
>   http://brewweb.devel.redhat.com/brew/taskinfo?taskID=1907424
> Can you test and verify, preferrably for PV and HVM guests, that this build
> fixes the problem?  

Don, 
I had a test, the rpm you sent us fixed the PV issue, and for HVM, it also works fine.

Comment 8 Hao, Xudong 2009-07-29 01:25:33 UTC
Verify BZ 514025 steps:
1): install RHEL5.4 Snap3 OS
2): uninstall the default xen in Snap3 
3): install rpm ball that Don made
4): hide devices that we want to do vtd assignment
5): create one PV guest with one device(02:00.0) assigned
6): in Dom0, using command "xm pci-list PV_guest_ID" to see PV domain's device. if succeed, dom0 will print: 
[root@localhost sda8]# xm pci-list 9
domain   bus   slot   func
0    2     0      0    

With this patch, the expected info shown by dom0, so this bug has gone with this patch.

Comment 9 Hao, Xudong 2009-08-05 06:20:48 UTC
Snap5 has not this patch in.

Comment 10 Chris Lalancette 2009-08-05 09:37:10 UTC
(In reply to comment #9)
> Snap5 has not this patch in.  

No, this has been deferred to 5.5.

Chris Lalancette

Comment 15 Yufang Zhang 2009-12-23 02:57:31 UTC
*** Bug 544947 has been marked as a duplicate of this bug. ***

Comment 18 errata-xmlrpc 2010-03-30 08:58:49 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0294.html

Comment 19 Paolo Bonzini 2010-04-08 15:51:20 UTC
This bug was closed during 5.5 development and it's being removed from the internal tracking bugs (which are now for 5.6).


Note You need to log in before you can comment on or make changes to this bug.