Created attachment 355345 [details] SPEC file Spec Attached Description: This package contains the standalone Courier IMAP server, which is used to provide IMAP access to local mailboxes
is this your first package ?
yes, my first package in bugzilla
looking at your spec file, I can see. BuildRequires: courier-authlib-devel courier-authlib these lines makes your package dependes on courier-authlib-devel courier-authlib, but these packages are not in fedora repos. so If you want to package courier-imap then you need to package the dependencies first. courier-authlib-devel courier-authlib :-)
you can grab the courier-authlib review here https://bugzilla.redhat.com/show_bug.cgi?id=486570 and continue the work.
Make the spec and SRPM available via http (or ftp) as instructed in http://fedoraproject.org/wiki/PackageMaintainers/Join#Upload_Your_Package
You can drop most of the %attr straight away, since the attributes given to the files in %install are preserved in the RPM (644,root,root for 'normal' files and 755,root,root for directories, libraries and executables). The config files %attr(0600,root,root) %{_sysconfdir}/imapd-ssl.dist %attr(0600,root,root) %config(noreplace) %{_sysconfdir}/imapd.cnf %attr(0600,root,root) %{_sysconfdir}/imapd.dist %attr(0600,root,root) %{_sysconfdir}/pop3d-ssl.dist %attr(0600,root,root) %config(noreplace) %{_sysconfdir}/pop3d.cnf %attr(0600,root,root) %{_sysconfdir}/pop3d.dist %attr(0600,root,root) %{_sysconfdir}/quotawarnmsg.example may need to have their attributes set separately, but I recommend doing it in %install and dropping the %attr lines from %files which are IMHO a bit messy: find $RPM_BUILD_ROOT%{_sysconfdir} -type f -exec chmod 600 {} \; (This will find all files in /etc and set the permissions to 600.)
(In reply to comment #5) > Make the spec and SRPM available via http (or ftp) as instructed in > http://fedoraproject.org/wiki/PackageMaintainers/Join#Upload_Your_Package I'm afraid, he cannot. User can get space on Fedorapeople only after someone will sponsor him.
(In reply to comment #7) > (In reply to comment #5) > > Make the spec and SRPM available via http (or ftp) as instructed in > > http://fedoraproject.org/wiki/PackageMaintainers/Join#Upload_Your_Package > > I'm afraid, he cannot. User can get space on Fedorapeople only after someone > will sponsor him. There's plenty of other (free) hosting available on the Internet, if he doesn't have a place yet.
(In reply to comment #8) courier-imap dependes on courier-authlib, feel free to review it first at. https://bugzilla.redhat.com/show_bug.cgi?id=486570
Spec URL: http://rafaelgomes.fedorapeople.org/courier-imap.spec SRPM URL: http://rafaelgomes.fedorapeople.org/courier-imap-4.5.1-2.fc11.src.rpm
Please don't forget this bug!
I can help review this.
For starters, 1. SHOULD: This has some potential conflicts or at least confusing bits with uw-imap (and other imap/pop3 providers): I'd suggest renaming man page items for starters including %{_mandir}/man8/imapd.8.gz => %{_mandir}/man8/imapd.8courier.gz Preferably too, generic binaries like: %{_bindir}/imapd => %{_bindir}/courier-imapd %{_bindir}/pop3d => %{_bindir}/courier-pop3d and generic config items, move something like: %{_sysconfdir}/* => %{_sysconfdir}/courier/ if at all possible. 2. MUST: License: GPLv3 with openssl exception (see COPYING) 3. SHOULD: include a startup script in /etc/rc.d/init.d/ ? See courier-imap.spec in tarball for an example 4. SHOULD: include pam configs ? See courier-imap.spec in tarball for an example
ping?
Rafael Gomes asked to post SPEC and RPMS in your account, I have no account to submit them. Once I update it post. I would anticipate that any recommendations were made.
Spec URL: http://techfree.com.br/archive/courier-imap.spec SRPM URL: http://techfree.com.br/archive/courier-imap-4.7.0-1.fc11.src.rpm
Ping! Any news? This package is very important for a Brazilian project, please help us. Thanks!
"Time passes and eternity approaches", Any News!?
courier-imap.src: E: description-line-too-long C This package contains the standalone Courier IMAP server, which is used to provide IMAP access courier-imap.src: E: description-line-too-long C to local mailboxes. Courier-IMAP is provided here as a separate package that can be used with courier-imap.src: W: non-standard-group System/Servers courier-imap.src: W: invalid-license GPLv3 with openssl exception courier-imap.src: W: invalid-license see COPYING courier-imap.src: W: strange-permission courier-imap.init 0755L SHOULD: drop or fix Group tag MUST: fix license, use something like this in .spec instead: # SSL exception, see COPYING License: GPLv3 with exceptions naming: ok SHOULD: drop unecessary BuildRequires: courier-authlib (which should already get pulled in from courier-authlib-devel) MUST: fix remaining generic namespace collisions, and use courier- prefix everywhere. examples include: /etc/pam.d/imap (since this currently Conflicts with cyrus-imap, grr, it should get fixed too ) SHOULD: other nice-to-have-fixed namespace issues include: %{_sysconfdir}/imapd-ssl.dist %{_sysconfdir}/imapd.cnf %{_sysconfdir}/imapd.dist %{_sysconfdir}/pop3d-ssl.dist %{_sysconfdir}/pop3d.cnf %{_sysconfdir}/pop3d.dist %{_datadir}/mkimapdcert %{_datadir}/mkpop3dcert %{_libexecdir}/imapd-ssl.rc %{_libexecdir}/imapd.rc %{_libexecdir}/pop3d-ssl.rc %{_libexecdir}/pop3d.rc (libexecdir could potentially just use %{_libexecdir}/courier/ subdir, for example) macros: NOT OK, MUST fix. See: http://fedoraproject.org/wiki/Packaging/Guidelines#Macros in particular, "Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python} is acceptable." init: SHOULD: update to include systemd unit file, instead of sysv init http://fedoraproject.org/wiki/Packaging/Guidelines#Systemd
ping reporter, been another couple of months... (sorry, for my own delays)
marking dead review, original reporter hasn't been heard from in years.
clearing review flag