Bug 514150 - Review Request: ibus-qt - The qt support tools for ibus
Summary: Review Request: ibus-qt - The qt support tools for ibus
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 503869
TreeView+ depends on / blocked
 
Reported: 2009-07-28 07:07 UTC by Peng Huang
Modified: 2010-07-29 00:12 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-08-11 05:31:09 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Peng Huang 2009-07-28 07:07:30 UTC
Spec URL: http://groups.google.com/group/ibus-devel/web/ibus-qt.spec
SRPM URL: http://groups.google.com/group/ibus-devel/web/ibus-qt-1.2.0.20090728-1.fc11.src.rpm
Description: The qt support tools for ibus

Comment 1 Parag AN(पराग) 2009-08-04 09:43:26 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1578478
+ rpmlint is silent for SRPM and for RPM.
- source files match upstream url
161ab8ff00361d010624933d6d430746d3a55348  ibus-qt-1.2.0.20090728-Source.tar.gz
b3ed5e0bcbab7c88f9745e8fc83ac10d684ed9ce  ../SOURCES/ibus-qt-1.2.0.20090728-Source.tar.gz

please update new SRPM with correct source

Comment 2 Peng Huang 2009-08-07 05:18:47 UTC
Just uploaded the latest tarball to upstream download page.

Comment 3 Parag AN(पराग) 2009-08-10 10:48:16 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1578478
- rpmlint is NOT silent for RPM.
ibus-qt.i686: W: one-line-command-in-%post /sbin/ldconfig
You should use %post -p <command> instead of using:  %post <command>  It will
avoid the fork of a shell interpreter to execute your command as well as
allows rpm to automatically mark the dependency on your command for the
excecution of the scriptlet.

ibus-qt.i686: W: one-line-command-in-%postun /sbin/ldconfig
You should use %postun -p <command> instead of using:  %postun <command>  It
will avoid the fork of a shell interpreter to execute your command as well as
allows rpm to automatically mark the dependency on your command for the
excecution of the scriptlet.

+ source files match upstream url
b3ed5e0bcbab7c88f9745e8fc83ac10d684ed9ce  ibus-qt-1.2.0.20090728-Source.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package ibus-qt-1.2.0.20090728-1.fc12.i686 =>
Provides: libibus-qt.so.1 libqtim-ibus.so
Requires: libQtCore.so.4 libQtDBus.so.4 libQtGui.so.4 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libdbus-1.so.3 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libibus-qt.so.1 libm.so.6 libpthread.so.0 librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH)
+ Package ibus-qt-devel-1.2.0.20090728-1.fc12.i686 =>
Requires: libibus-qt.so.1
+ Not a GUI application

Suggestions:
1)Fix rpmlint messages before cvs import.

APPROVED.

Comment 4 Peng Huang 2009-08-11 02:20:17 UTC
OK. Thanks.

Comment 5 Peng Huang 2009-08-11 02:23:14 UTC
New Package CVS Request
=======================
Package Name: ibus-qt
Short Description: The qt support tools for ibus
Owners: phuang
Branches: F-10 F-11
InitialCC:

Comment 6 Kevin Fenzi 2009-08-11 05:07:32 UTC
cvs done.

Comment 7 Peng Huang 2009-08-11 05:31:09 UTC
Thanks
Imported ibus-qt, and built it for rawhide.

Comment 8 Fedora Update System 2009-10-05 08:06:04 UTC
ibus-qt-1.2.0.20090822-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/ibus-qt-1.2.0.20090822-2.fc11

Comment 9 Fedora Update System 2009-10-27 07:08:59 UTC
ibus-qt-1.2.0.20090822-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Jens Petersen 2010-07-29 00:12:56 UTC
Late comment, but just noticed COPYING missing from %doc list:
sending a patch to Fujiwara-san since cvs/git is in outage.


Note You need to log in before you can comment on or make changes to this bug.