Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-flexmock/rubygem-flexmock.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-flexmock/rubygem-flexmock-0.8.6-1.fc.src.rpm Description: FlexMock is a simple, but flexible, mock object library for Ruby unit testing. Koji scratch build: For F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1563090 For F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1563094
rpmlint is complaining: ruby-flexmock.noarch: W: no-documentation ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/validators.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/validators.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock.rb ../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/argument_matchers.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/argument_matchers.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/argument_types.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/argument_types.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/ordering.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/ordering.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/expectation.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/expectation.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/noop.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/noop.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/partial_mock.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/partial_mock.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/test_unit.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/test_unit.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/core_class_methods.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/core_class_methods.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/recorder.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/recorder.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/base.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/base.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/errors.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/errors.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/expectation_director.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/expectation_director.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/rails/view_mocking.rb ../../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/rails/view_mocking.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/core.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/core.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/default_framework_adapter.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/default_framework_adapter.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/mock_container.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/mock_container.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/composite.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/composite.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/rspec.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/rspec.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/deprecated_methods.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/deprecated_methods.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/undefined.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/undefined.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/rails.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/rails.rb ruby-flexmock.noarch: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/flexmock/test_unit_integration.rb ../../../gems/1.8/gems/flexmock-0.8.6/lib/flexmock/test_unit_integration.rb rubygem-flexmock-doc.noarch: W: no-documentation are you able to fix it somehow? other checks: -source url ok -legible spec file -ruby specific guidelines & packaging guidelines ok -md5sum for source gem ok -build ok -requires/BR ok -licence ok -macros ok -name ok -directory/file owner - ok
Well, For ruby-flexmock: - no-documentation rpmlint can be ignored because this requires rubygem-flexmock and all needed documents are there. - dangling-relative-symlinks are really be resolved by installing rubygem-flexmock which ruby-flexmock requires correctly. And rubygem-flexmock-"doc" is for documents so I don't think I should mark files in this -doc subpackage as %doc explicitly
yeah, have same opinion on it. Approved
Thank you! New Package CVS Request ======================= Package Name: rubygem-flexmock Short Description: Mock object library for ruby Owners: mtasaka Branches: F-11 F-10 InitialCC: (nobody)
CVS done.
Rebuild done, push request submitted on bodhi, closing. Thank you for the review and CVS procedure.
Mamoru Tasaka, would you be interested in branching ruby-flexmock for EPEL5? If not, I'd be happy to co-maintain in EPEL. We could use it to rebuild rake, and then activeldap for EPEL5. stahnma
No. Please feel free to maintain any packages of mine on EPEL. Currently I own the owership of rubygem-{hoe,activeldap} on EPEL 5, however if you want I will release these ownership on EPEL branches for you.
New Package CVS Request ======================= Package Name: rubygem-flexmock Short Description: Mock object library for ruby Owners: stahnma Branches: EL-5 InitialCC: (nobody)
cvs done.