Bug 514654

Description of problem:


When nfsv4-client used expired stateid which generated 'lease_time' seconds ago,
nfsv4-server return NFS4ERR_BAD_STATEID, but according to RFC3530, nfsv4-server
should return NFS4ERR_EXPIRED in this case.


--
[RFC3530] 8.6.3.  Network Partitions and Recovery

If the duration of a network partition is greater than the lease
period provided by the server, the server will have not received a
lease renewal from the client.  If this occurs, the server may free
all locks held for the client.  As a result, all stateid held by the
client will become invalid or stale.  Once the client is able to
reach the server after such a network partition, all I/O submitted by
the client with the now invalid stateid will fail with the server
returning the error NFS4ERR_EXPIRED.
--


Version-Release number of selected component (if applicable):

Kernel 2.6.18-128

How reproducible:

Every time.

Steps to Reproduce:

Server:

0. mkdir -p /work/nfs
1. Add "/work/nfs *(rw,insecure,no_root_squash,fsid=0)" to /etc/exports
2. echo 90 > /proc/fs/nfsd/nfsv4leasetime
3.service nfs restart

0. mkdir -p /mnt/point
1. mount -t nfs4 server:/work/nfs /mnt/point
2. gcc -o nfs_test nfs_test.c
3. ./nfs_test serverip

Actual results:

Fail: CLOSE after lease timeout should return NFS4ERR_EXPIRED, instead got NFS4ERR_BAD_STATEID

Expected results:

Pass: CLOSE after lease timeout server return NFS4ERR_EXPIRED

Additional info:

I've done initial testing of this patch, it seems sane, ran it through the connectathon tests, no additional tests failed.