Bug 514721 - make screws up shell command
Summary: make screws up shell command
Alias: None
Product: Fedora
Classification: Fedora
Component: make
Version: rawhide
Hardware: x86_64
OS: Linux
Target Milestone: ---
Assignee: Petr Machata
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2009-07-30 13:38 UTC by Martin Stransky
Modified: 2015-05-05 01:34 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-10-05 17:59:31 UTC
Type: ---

Attachments (Terms of Use)
testcase (222 bytes, text/plain)
2009-07-30 13:38 UTC, Martin Stransky
no flags Details

Description Martin Stransky 2009-07-30 13:38:14 UTC
Created attachment 355673 [details]

Description of problem:

Make fails to perform given shell script. Makefile is attached.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. copy in the testcase
2. make -n
Actual results:
{ \
mgBu nsImgBuildDefines.tmp

Expected results:
{ \
} > nsImgBuildDefines.tmp

Additional info:

It breaks building of all mozilla based packages (xulrunner/seamonkey/thunderbird) in koji/rawhide. Seems to be x86_64 specific (builds went fine on i386).

Comment 1 Petr Machata 2009-07-30 14:45:09 UTC
Can't reproduce on F11.  That the same binary works on F11 and fails in Rawhide is strange, and might indicate that the bug originates elsewhere in the stack.  Will get Rawhide machine and try to reproduce there.

Comment 2 Petr Machata 2009-07-31 10:18:37 UTC
Just tried to run valgrind on the thing, and got this:

==28578== Source and destination overlap in strcpy(0x4C7B014, 0x4C7B01C)
==28578==    at 0x4A07EA8: strcpy (mc_replace_strmem.c:268)
==28578==    by 0x40E4DF: (within /usr/bin/make)
==28578==    by 0x4196EB: (within /usr/bin/make)
==28578==    by 0x419D1E: (within /usr/bin/make)
==28578==    by 0x4117B6: (within /usr/bin/make)
==28578==    by 0x34E2E1EA2C: (below main) (in /lib64/libc-2.10.1.so)

I suspect this might actually be the reason for what you see.  glibc on F12 perhaps changed some detail of strcpy implementation, so the error manifests itself there.

Comment 3 Petr Machata 2009-07-31 12:00:39 UTC
I built a package that fixes the above strcpy problem, and therefore might resolve this bug.  Could you please test it and report back?

Comment 4 Jan Horak 2009-08-03 13:16:53 UTC
With new package of make it WFM (thunderbird and seamonkey package).

Comment 5 Adam Williamson 2009-10-05 17:59:31 UTC
the fixed build was shipped in rawhide, ergo closing.

Fedora Bugzappers volunteer triage team

Note You need to log in before you can comment on or make changes to this bug.