Description of problem:
Currently, Simple Paged Results and GER returns response control per-entry.
Since per entry-response controls (except for persistent search EntryChange
controls) are ignored by the ldapsearch client, we are getting rid of the
unnecessary write_controls calls for Simple Paged Results.
(In reply to comment #0)
> we are getting rid of the
> unnecessary write_controls calls for Simple Paged Results.
Created attachment 355712 [details]
git patch file for result.c
Fix description: Getting rid of the unnecessary write_controls calls for GER and Simple Paged Results.
Note: both GER and Simple Paged Results add its control to the result controls maintained in the "operation" and they are sent to the client via send_ldap_result.
Thanks to Nathan for the review.
Pushed to master.
$ git merge paged
ldap/servers/slapd/result.c | 30 ------------------------------
1 files changed, 0 insertions(+), 30 deletions(-)
$ git push
Counting objects: 11, done.
Delta compression using 4 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 649 bytes, done.
Total 6 (delta 4), reused 0 (delta 0)
7c52ad5..7a4fce4 master -> master
can you please add steps to verify this bug? Thanks!
(In reply to comment #4)
> can you please add steps to verify this bug? Thanks!
I'm afraid there is no way to verify this bug with a black box test. It's a pure server internal issue -- getting rid of unnecessary return control. Since GER and Simple Paged Results acceptance tests are passing 100%, I think we could say this bug is verified.
Thanks Noriko - marking verified.