Spec URL: http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util.spec SRPM URL: http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util-3.12.4-1.src.rpm Description: Utilities required by Network Security Services and its Softokn Cryptographic Module.
nss-util is one of two packages, nss-softokn being the other, that are being proposed as spin-off of the full NSS package. Please hold-off reviewing it until I get the other one ready for submission.
What's your ID in the Fedora account system? A search didn't turn anything up.
My ID is emaldonado.
Ah, I searched for Batiz. Looks like you're set there. However, since you've asked that this not be reviewed yet, I'll indicate that it's not ready. Please clear the whiteboard when you'd like for someone to review this.
(In reply to comment #0) Changed the source rpm to SRPM URL: http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util-3.12.3.99.3-1.fc11.src.rpm
Since this is for Fedora 12 a more adequate source rpm would be http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util-3.12.3.99.3-1.fc12.src.rpm
(In reply to comment #4) > Ah, I searched for Batiz. Looks like you're set there. However, since you've > asked that this not be reviewed yet, I'll indicate that it's not ready. Please > clear the whiteboard when you'd like for someone to review this.
(In reply to comment #4) Now cleared.
I'm wondering if I set a wrong flag somewhere since no one has taken this for review and the code freeze for fedora 12 alpha is today.
(In reply to comment #9) Checking the "need additional information" box was a bad idea. the Request for review got cancelled, how to I reactivate it?
In case you aren't aware there are 550 package review tickets in the queue to be looked at. We have far too few reviewers to be able to look at any ticket instantaneously. You should certainly expect to wait more than four hours.
Based on review comments from Bug 515034, which depends on this one, I have updated the spec file Spec URL: http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util.spec and created a new source rpm SRPM URL: http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util-3.12.3.99.3-8.fc11.test.1.src.rpm Though it says fc11 it's intended for fc12.
I have updated the contents of the URLs. Also did a scratch build and installed nss-util and nss-softokn in a virtual machine. As part of the split and nss-util (nss-util-devl actually) needs to become the owner of the /usr/includes/nss3 directory. This is fine if you are doing a clean install of Fedora 12. If someone does and update to F12 nss from F11 where nss is already there thre will be conflicts because nss was the previous owner. I had to execute rpm -ihv nss-util-*.rpm --force. Even tough a clean install of F12 is strongly recommended some users do update from F-11 to F-12 and will face those conflicts. How is changing of ownership of directories upon splits customarily handled?
1. URL - points to a generic NSS page. Is there a worry that mozilla may move the actual FTP site around. See http://fedoraproject.org/wiki/Packaging/SourceURL for examples. I believe this tar was pulled for an NSS cvs tag and then the split.sh was ran on it. The wiki has examples for this case (you've partially included the right thing with the comment and conclusing of the nss.split.sh script. 2. You are creating a new empty directory %{libdir}/nss3 is there a reason (if so comment it, if not remove it). 3. the %define nspr-version should technically be %global 4. uncomment the Requires: nss-util in the nss-util-devel package section. 5. This last on is the biggest one: The issue showed up in multiple locations, including rpmlint. In the %build you are creating nss-util.pc and nss-util-config and placing them into the build root. This is a non-standard use of the build root, and requires the first command in %install which clears the buildroot to be removed. A better way would be to create nss-util.pc and nss-util-config in %build and place the results in mozilla/dist (where NSS build results are placed), then install them into their final location in the %include.
rpmlint output: bobs-laptop(79) rpmlint nss-util-3.12.3.99.3-8.fc11.test.1.src.rpm nss-util.src: W: strange-permission nss-split-util.sh 0775 nss-util.src:97: W: rpm-buildroot-usage %build %{__mkdir_p} $RPM_BUILD_ROOT/%{_libdir}/pkgconfig nss-util.src:104: W: rpm-buildroot-usage %build $RPM_BUILD_ROOT/%{_libdir}/pkgconfig/nss-util.pc nss-util.src:114: W: rpm-buildroot-usage %build %{__mkdir_p} $RPM_BUILD_ROOT/%{_bindir} nss-util.src:122: W: rpm-buildroot-usage %build > $RPM_BUILD_ROOT/%{_bindir}/nss-util-config nss-util.src:124: W: rpm-buildroot-usage %build chmod 755 $RPM_BUILD_ROOT/%{_bindir}/nss-util-config 1 packages and 0 specfiles checked; 0 errors, 6 warnings. < and just for the .spec, which has better line numbers > rpmlint nss-util.spec nss-util.spec:100: W: rpm-buildroot-usage %build %{__mkdir_p} $RPM_BUILD_ROOT/%{_libdir}/pkgconfig nss-util.spec:107: W: rpm-buildroot-usage %build $RPM_BUILD_ROOT/%{_libdir}/pkgconfig/nss-util.pc nss-util.spec:117: W: rpm-buildroot-usage %build %{__mkdir_p} $RPM_BUILD_ROOT/%{_bindir} nss-util.spec:125: W: rpm-buildroot-usage %build > $RPM_BUILD_ROOT/%{_bindir}/nss-util-config nss-util.spec:127: W: rpm-buildroot-usage %build chmod 755 $RPM_BUILD_ROOT/%{_bindir}/nss-util-config 0 packages and 1 specfiles checked; 0 errors, 5 warnings.
Bob, Please check the updated .spec and src.rpm files at http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util.spec and at http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util-3.12.3.99.3-8.fc12.test.1.src.rpm
neither the original nss, not this package ever puts any shared libraries in /usr/lib/nss3, so you should remove the creation of that directory and it's ownership in the .spec file
(In reply to comment #17) Line and comments above removed. Updated the .spec and srpm.
OK, much better. ACCEPT. bob
New Package CVS Request ======================= Package Name: nss-util Short Description: Network Security Services Utility Module Owners: emaldonado, kengert, rrelyea Branches: F-12 InitialCC: emaldonado, kengert, rrelyea
You cannot request F-12 branches at this time. Otherwise, CVS done.