Spec URL: http://chessgriffin.com/files/pkgs/fedora/tint2/tint2.spec SRPM URL: http://chessgriffin.com/files/pkgs/fedora/tint2/tint2-0.7.1-1.fc11.src.rpm Description: tint2 is a simple X11 desktop panel and taskbar intentionally made for Openbox3, but that should work with other window managers. tint2 is intended to be unintrusive and light in resource utilization, while following freedestkop specifications. Home page: http://code.google.com/p/tint2 This is my second submission. Rpmlint -vi is clean on spec, SRPM, and RPM. Builds cleanly in mock. Built cleanly on koji scratch build for f11 (https://koji.fedoraproject.org/koji/taskinfo?taskID=1575660) and f12 (https://koji.fedoraproject.org/koji/taskinfo?taskID=1576012).
I suggest that you drop --docdir=%{_docdir}/%{name}-%{version} and just run rm -rf %{buildroot}%{_docdir} explicitly at the end of install, since rpm anyway removes the documentation directory. ** rpmlint output is clean. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. OK - You may want to change %{_mandir}/man1/tint2.1.gz to %{_mandir}/man1/tint2.1.* in case the man page compression format changes in the future. MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSWORK - Add COPYING to %doc. MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK ** You still need to do the informal reviews. Please review only bugs not marked with FE-NEEDSPONSOR.
ping?
Sorry, I had this done last week but have not had an opportunity to post back. Updated Spec: http://chessgriffin.com/files/pkgs/fedora/tint2/tint2.spec Updated SRPM: http://chessgriffin.com/files/pkgs/fedora/tint2/tint2-0.7.1-2.fc11.src.rpm Spec, SRPM, and RPM are rpmlint clean. Builds cleanly in x86_64 and i386 F11 mock. Builds cleanly in dist-f11 koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1601993 Builds cleanly in dist-f12 koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1602016 I am still trying to get to the informal reviews when I have the chance.
ping
Random rant of the day: tint2 uses 'orage' (XFCE calendar) as default app when clicking onto the clock but orage isn't a Require of the pkg. IMHO orage makes sense and should be added as Require.
Thanks for the ping. I am going to refocus on this one.
(In reply to comment #7) > Thanks for the ping. I am going to refocus on this one. Hi Chess, I have just made a spec myself for tint2 for a friend to use. If you want a hand give me shout and I will happily do so. Can also offer to co-maintain with you if you want? (In reply to comment #5) > Random rant of the day: > tint2 uses 'orage' (XFCE calendar) as default app when clicking onto the clock > but orage isn't a Require of the pkg. > > IMHO orage makes sense and should be added as Require. IMHO orage is optional if you search on google code for tint2 there is a standalone light calendar thats not orage that is deigned to work with tint2 also. You might as well make libpurple facebook plugin Required for Pidgin, its the same principle.
Here are my updated SPEC and SRPM: http://chessgriffin.com/files/pkgs/fedora/tint2/tint2.spec http://chessgriffin.com/files/pkgs/fedora/tint2/tint2-0.9-1.fc12.src.rpm This builds ok in mock and for dist-f12, dist-f13, and dist-f14 in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=2016772 https://koji.fedoraproject.org/koji/taskinfo?taskID=2016789 https://koji.fedoraproject.org/koji/taskinfo?taskID=2016800 I added a patch to fix a DSO Linking issue. I will send this patch upstream if it looks ok to reviewers, and I'll also add a comment to that effect (if it's not accepted upstream). John, thanks for your offer and I would definitely appreciate your input and co-maintainership. I am not yet an approved packager/maintainer and have been unable to find the time to do some thorough reviews. I've packaged stuff for other distros and also FreeBSD, so while RPM packaging is different, of course, I have an understanding of how packaging works in general. So working with a co-maintainer would be good training. :-) I also agree that orage should not be a Require. I use tint2 with openbox and other WM's and would hate to see orage pulled in by default. It's also like the default menus entries in fluxbox -- those aren't pulled in, AFAIK.
John - thank you for the ping. As I mentioned in my last comment, I am definitely interested in co-maintaining and was just waiting for some feedback on the last spec/srpm. Since I am interested in packaging, I do plan to try and focus on some reviews, but in the meantime, I welcome further feedback on the tint2 spec/srpm. Thanks!
I can confirm it still builds ok in dist-f13, dist-f14, and dist-rawhide in Koji.
Is this review still alive ? I can't access to the SRPM.
Hello Chess: Are you still interested in this package? If yes, please update it to version 0.11. The installation method changed, please see here: http://code.google.com/p/tint2/wiki/Install#Install_Manually If not, I would like to submit it again. I have my package ready and last version. Regards, Germán.
German, I do not have time at the moment to update the spec, so please feel free to submit your package. This review can be closed. Thanks!
Who can close this review? Myself?
Sorry Chess, this one must have slipped under my radar. Next time, feel free to ping. Germán: if it's still OK with Chess, you can make up a new review request and mark this one as its duplicate.
OK Jussi, as Chess said that he has no more time to dedicate to this package, I'm going to open a new review request. Regards, Germán,
*** This bug has been marked as a duplicate of bug 615153 ***