Bug 515312 - [Broadcom 5.5 feat] Update tg3 and add support for 5717/5718 and 57765 asic revs
Summary: [Broadcom 5.5 feat] Update tg3 and add support for 5717/5718 and 57765 asic revs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: 5.5
Assignee: John Feeney
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
: 511982 515006 (view as bug list)
Depends On:
Blocks: 481160 513912 514243 525215 533192 533941 557292
TreeView+ depends on / blocked
 
Reported: 2009-08-03 16:59 UTC by Matt Carlson
Modified: 2010-10-15 20:09 UTC (History)
16 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 07:17:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
tg3: Patches for 5717 and other fixes (13.01 KB, application/gzip)
2009-12-16 00:21 UTC, Matt Carlson
no flags Details
Install RH5.5 x86 snapshot 3 error (3.91 MB, image/jpeg)
2010-03-04 10:31 UTC, Jeff Leu
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description Matt Carlson 2009-08-03 16:59:46 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Andrius Benokraitis 2009-08-24 17:58:01 UTC
*** Bug 511982 has been marked as a duplicate of this bug. ***

Comment 2 Andrius Benokraitis 2009-08-24 17:58:14 UTC
*** Bug 515006 has been marked as a duplicate of this bug. ***

Comment 9 Chris Ward 2009-10-13 15:25:51 UTC
@Broadcom,

We need to confirm that there is commitment to test 
for the resolution of this request during the RHEL 5.5 test
phase, if it is accepted into the release. 

Please post a confirmation before Oct 16th, 2009, 
including the contact information for testing engineers.

Comment 10 Matt Carlson 2009-10-13 18:35:26 UTC
Yes, we will test this.

Comment 11 IBM Bug Proxy 2009-10-13 18:42:32 UTC
------- Comment From lcm.com 2009-10-13 14:34 EDT-------
IBM signing up to provide test feedback. Please coordinate kernel/driver availability through Peter Bogdanovic, pbogdano.com.

Comment 12 John Jarvis 2009-10-23 16:49:19 UTC
This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

Comment 13 Andrius Benokraitis 2009-11-17 20:16:30 UTC
Matt - I'm going to assume 5718 support is *not* in this release?

Comment 14 Michael Chan 2009-11-17 20:30:37 UTC
Andrius, 5718 is in the same family as 5717 and we plan to support the whole 5717/5718 family in RHEL5.5.

Comment 15 Andrius Benokraitis 2009-11-17 20:36:09 UTC
Good to know - thanks Michael!

Comment 16 John Feeney 2009-12-01 21:59:12 UTC
Test kernels with the posted patch can be found at
http://people.redhat.com/jfeeney/.rhel5-tg3

This posted patch contains the following upstream patches:
 1. Glendinning - Move flow control to mii.h
    e18ce3465477502108187c6c08b6423fb784a313 (12/16/08)
2. Glendinning - Refactor full duplex
    bc02ff95fe4ebd3e5ee7455c0aa6f76ebe39ebca (12/16/08)
3. Carlson - Remove unused cfgspc device members
    69fc405318967c7913e5b55cf3906250a26b49d0 (12/22/08)
4. Carlson - tg3.h cleanups
    aa10f27d99410cff9145bf91b6efc884c7a4871c (12/22/08)
5. Carlson - version 3.97
    d3d317092b58a6df1d31a4ca90cdb9d2bd4ebffa (12/10/08)
6. Kluin - limit reaches -1
    d4675b52a933831d4901217564cba5a434ddd922 (2/13/09)
7. Carlson - Fix 5906 link problems
    a6435f3a53746a0eb687a9f636cf1941f35f935e (2/27/09)
8. Carlson - Drop non-VLAN rx pkts
    f7b493e02101bb5a0a69a91a8b4b7b002cd60eaf (2/27/09)
9. Carlson - update ethtool set_settings error checks
    7e5856bd9644e2299adbf5d0a8916f9cc56f1f36 (2/27/09)
10. Carlson - redefine tg3_vlan_rx_register()
     844b3eed8a9efffa4225c811b989c8ff41691a78 (2/27/09)
11. Carlson - Eliminate nvram routine forward declarations
     ffbcfed441b9ba74ce77f215eed6925f6a0b82a3 (2/27/09)
12. Carlson - invert nvram_read and nvram_read_swab
     e4f341103e4a2b35f56a0f89802f1b1448e8d04b (2/27/09)
13. Carlson - Correct NVRAM stream endian notations
     a9dc529dcd5c541c51cb2ba09bff99580361c576 (2/27/09)
14. Carlson - Eliminate tg3_nvram_read_swab()
     6d348f2c1e0bb1cf7a494b51fc921095ead3f6ae (2/27/09)
15. Carlson - Refactor firmware version routines
     acd9c119cc663860fff4f1445ed0f87d82378d99 (2/27/09)
16. Carlson - Add legacy bootcode decoding
     ff3a7cb25217bddcefd20e72af08a65481db4096 (2/27/09)
17. Carlson - Add DASH firmware version reporting
     7fd764455a13f4d9b37c9b908f07d0758f11d3c5 (2/27/09)
18. Carlson - Add version reporting for hardware selfboot
     a6f6cb1cf8ba54efdbbbf61b5b4345b0246da42f (2/27/09)
19. Carlson - 3.98 Feb 2009
     0d2a5068aaa238eba971784585e44130db6d4759 (2/27/09)

20. Carlson - Fix 5906 link problems
     9f8ac0b7b063be77f0de7a27fe5e6a0aa2cce58d (3/4/09)
21. Andrew - Fix misspelling of firmware
     877d03105d04b2c13e241130277fa69c8d2564f0 (3/30/09)
22. Yang - dma_mapping: replace all DMA64BIT_MASK
     6a35528a8346f6e6fd32ed7e51f04d1fa4ca2c01 (4/7/09)
23. Yang - dma_mapping: replace all DMA40BIT_MASK
     50cf156af7dc68a44409bef636585ef88ebbab34 (4/7/09)
24. Yang - dma_mapping: replace all DMA32BIT_MASK
     284901a90a9e0b812ca3f5f852cbbfb60d10249d (4/7/09)
25. Bottomley - fix big endian MAC addr collection failure
     0d489ffb76de0fe804cf06a9d4d11fa7342d74b9 (4/13/09)
26. Carlson - Fix SEEPROM accesses
     62cedd11f63c99efd2962fb69763a09e2778f6e6 (4/20/09)
27. Carlson - Handle NVRAM absent cases
     df259d8cba7d7880dc04d34c7a6e0ce15fbc9644 (4/21/09)
28. Carlson - Prevent send BD corruption
     33466d938f43ab65312466ba5472b9c6ee200cce (4/21/09)
29. Carlson - Allow 5761 WOL and LED fixes to 5761S
     8d519ab2866c92f5d722085492a124f016f601aa (4/21/09)
30. Carlson - Limit CLKREQ fix to A[01] of 57780 asic rev
     9cf74ebb634fe79587cf9a1d5ff971391dd12e1b (4/21/09)
31. Carlson - Restore LAA sooner in shutdown
     daba2a631d2b7831b6a021b36d61314a9153526e (4/21/09)
32. Carlson - Version 3.99 April 20, 2009
     bb9e63e27117b469a151c61fb0045a8ec4cced5d (4/21/09)
33. Carlson - Fix 57780 asic rev PCIe link receiver errors
     521e6b90dd3f0392062845d7ef13e6e41bb99d8a (8/26/09)
34. Carlson - Prevent tx BD corruption
     255ca311b650caece3ec4f78b88ef298664d561f (8/26/09)
35. Carlson - Fix TSO test against wrong flags var
     29ea095fb727ac48228ff2d1af484c27bf1dcbd4 (8/26/09)
36. Carlson - Add 57788, remove 57720
     5e7ccf2003e6a9c35b5aa24953ba5009a1a8b653 (8/26/09)
37. Carlson - Create MII_TG3_FET namespace
     535ef6e1124d445efbcc13b7126561dc544b0b64 (8/26/09)
38. Carlson - VERSION 3.100 Aug 25, 2009
     f656f39801b00c3c2aa26cefbdee2775d6706d45 (8/26/09)

39. Carlson - Delay mdio bus init until fw finishes
     0a9140cff22e405fce1747a2e02d41851c36c55a (8/29/09)
40. Carlson - Add new 5785 10/100 only device ID
     2befdcea96fcd9a13e94373c66ea1dd7365d2a74 (8/29/09)
41. Carlson - Reformat NVRAM case statements
     8590a603e5e20ccf49d6cf0ea71ecf5388d1f9da (8/29/09)
42. Carlson - Break out mini producer ring handling
     fdb72b38c94c0ead1f78ecc8db64b832feda22c3 (8/29/09)
43. Carlson - Move the JUMBO_CAPABLE and SUPPORT_MSI flags
     8f666b07ac53eeedd6c035adf6d4299f9ed0df2d (8/29/09)
44. Carlson - Clarify rx buffer relationship
     287be12e1774d842bff21ea0c1809c2387d7b310 (8/29/09)
45. Carlson - Create rx producer ring setup routines
     cf7a7298c4f47ab7546b933bb54ad3ea03a1daf6 (8/29/09)
46. Carlson - Create a new prodring_set structure
     21f581a5366d48d86b9ae86043fc61d44e992c0c (8/29/09)
47. Carlson - Use ext rx bds
     79ed5ac7ddd5f8d6463f5a17b3575772e9896481 (8/29/09)
48. Carlson - Cleanup interrupt setup
     07b0173cb5d6a9d77646cd855066ebe90b9203f2 (8/29/09)
49. Carlson - Move napi to per-int struct
 my dummy_netdev changes plus tg3.h (struct tg3_napi)
     8ef0442f98850333196bc56415192e52a6267878
50. Carlson - Convert ISR parameter to tnapi
following gospo's suggestions
     09943a1819a240ff4a72f924d0038818fcdd0a90 (8/29/09)
51. Carlson - Convert napi handlers
     17375d25d3dcd3d4caf9456fa94f60e29d6b1146 (8/29/09)
52. Carlson - Move general int members to a per-int struct
     898a56f8d8170c188e47ae3acb90d2ea9a585ebe (8/29/09)
53. Carlson - Move per-int rx members to per-int struct
     723344820aa405ac2663ab9e36fd27833d06129b (8/29/09)
54. Carlson - Move per-int tx members to a per-int struct
     f3f3f27e5b4e27737f824535e6f145a3c88b976c (8/29/09)
55. Carlson - Version 3.101 August 28, 2009
     fc57e515a2c02599b00d252545521288dfc0158a (8/29/09)

56. Carlson - in line tg3_cond_int()
     f19af9c2cc015e42dfe4bd5c383e32066ec2801c (9/2/09)
57. Carlson- add per-int coalesce now member napi
     fd2ce37f8e4a570ce90b141a2e7c476c5b399836 (9/2/09)
58. Carlson- Create tg3_rings_reset()
     2d31ecaf10c4ae03d49aed516481b2839b0220f6 (9/2/09)
59. Carlson- Add support code around kernel interrupt API
     4f125f42dd55390016e21f8b3960f99d02d1001f (9/2/09)
60. Carlson- Add MSI-X support
     679563f47cd2547a0e091b5bd3ddf30027af6b08  (9/2/09)
61. Carlson - Add mailbox assignment
     646c9eddcffd202bb0f3d906cecf94eaf10cad31 (9/2/09)
62. Carlson - Add tx and rx ring resource tracking
     f77a6a8e6cee17b21a43bdf6b853cc2fc0e2c4df (9/2/09)
63. Carlson - Update intmbox and coal_now for msix
     89aeb3bceaa1a02651206a76a7b9dcb8f3884702 (9/2/09)
64. Carlons - Add coalesce parameters for msix vectors
     b6080e126012047d42e53154189fdca286d0600e (9/2/09)
65. Carlson - Add RSS
     baf8a94a572928710e9e60967d153a7bf3aebd9c (9/2/09)
66. Carlson - Adjust RSS ring allocation strategies
     0c1d0e2b05e92ad847b3ebe1c75b7974086bc8fa (9/2/09)
67. Carlson - Assign rx net producer indexes by vector
     8d9d7cfc0ec2fe37ff9afd74326d03f38f96ad1b (9/2/09)
68. Carlson - Add 5717 asic rev
     f6eb9b1fc1411d22c073f5264e5630a541d0f7df (9/2/09)
69. Carlson - Add 5717 NVRAM detection routines
     a1b950d56de3c72bea3343f54de24c43fb7dc74e  (9/2/09)
70. Carlson - Add MDIO bus address assignments
     882e9793faa9425dff581c33b1af45ed10145626 (9/2/09)
71. Carlson - 3.102 September 1
     daf09de817353f18bb81a23a023d429cfd258e62 (9/2/09)

72. Hutchings - Remove redundant checks
     7ab0f2736bfe137a82a7084bbfb5f809da95cabd (9/4/09)
73.Carlson - Fix return ring size breakage (9/11/09)
     5ea1c50662d447de344812054175d7151783ea25

From here on, the patches come from netdev mail list.
 (netdev.vger.kernel.org)

74. Carlson - Assign flags to fixes in start_xmit_dma_bug()
     1/20 11/2/2009
75. Carlson - Fix 5906 transmit hangs
     2/20 11/2/2009
76. Carlson - Fix disappearing 57780 devices okay
     3/20 11/2/2009
77. Carlson - Prevent a PCIe tx glich
     5/20 11/2/2009
78. Carlson - Improve 5785 PCIe performance
     7/20 11/2/2009
79. Carlson - Add AC131 power down support
     8/20 11/2/2009
80. Carlson - Extend loopback test timeout
     10/20 11/2/2009
81. Carlson - 3.103 November 2, 2009
     20/20 11/2/2009

82. Carlson - Add 5717 phy ID
     1/20 11/13/2009
83. Carlson - Dont touch RCB nic addresses
     2/20 11/13/2009
84. Carlson - Move TG3_FLG2_PROTECTED_NVRAM to tg3_flg3
     4/20 11/13/2009
85. Carlson - Allow DMAs to cross cacheline boundaries
     8/20 11/13/2009
86. Carlson - Move napi_add calls below tg3_get_invariants
     10/20 11/13/2009
87. Carlson - Make tg3_alloc_rx_sbk() a dst-only operation
     11/20 11/13/2009
88. Carlson - Add prodring parameter to tg3_alloc_rx_rsb()
     12/20 11/13/2009
89. Carlson - tg3_alloc_rx_skb(tnapi => tp)
     13/20 11/13/2009
90. Carlson - rename rx_[std|jmb]_ptr to rx_[std|jmb]_prod_idx
     14/20 11/13/2009
91. Carlson - Consider rx_std_prod_idx a hw mailbox
     15/20 11/13/2009
92. Carlson - Lay proucer ring handling groundwork
     16/20 11/13/2009
93. Carlson - Fix DIDs, Enable 5717 support
     19/20 11/13/2009
94. Carlson - 3.104 Nov 13, 2009
     20/20 11/13/2009

Even though I tested this internally, any testing that can be performed on this kernel would be appreciated.

Comment 17 Matt Carlson 2009-12-10 02:46:32 UTC
With the 5717, our QA department reports that the kernel hangs on boot while bringing up the device.  I can confirm this behavior.  Can I get access to the tg3 sources so that I can debug the problem and submit a patch?

Comment 20 Matt Carlson 2009-12-16 00:21:50 UTC
Created attachment 378662 [details]
tg3: Patches for 5717 and other fixes

This archive contains 12 patches that fix some of the problems encountered with the 2.6.18-169.el5.test test kernel.  There are a lot of changes so I intentionally chose to value reduced linecount over upstream source alignment.  The last patch in this patchset adds 57765 support and has been minimally tested.

Comment 21 John Feeney 2009-12-18 15:23:06 UTC
The posted patch set failed internal testing by causing panics when running with the debug kernel. Thus, I am taking it out of POST state and back to ASSIGNED.

Comment 22 John Feeney 2009-12-18 16:38:23 UTC
Reposted a patch that updates tg3.c to version 3.100 (Aug 25, 2009). This is abreviated from the originally posted patch due to panics that occurred when testing. The remainder of the update to tg3 (beyond 3.100) will be dealt with in bz545135.

Comment 31 Chris Ward 2010-02-11 10:07:20 UTC
~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~

RHEL 5.5 Beta has been released! There should be a fix present in this 
release that addresses your request. Please test and report back results 
here, by March 3rd 2010 (2010-03-03) or sooner.

Upon successful verification of this request, post your results and update 
the Verified field in Bugzilla with the appropriate value.

If you encounter any issues while testing, please describe them and set 
this bug into NEED_INFO. If you encounter new defects or have additional 
patch(es) to request for inclusion, please clone this bug per each request
and escalate through your support representative.

Comment 32 IBM Bug Proxy 2010-02-17 22:08:09 UTC
------- Comment From coschult.com 2010-02-17 16:53 EDT-------
Verified Beta 1 on a Broadcom 5721 PCIe adapter. Driver present
after booting and card detected. Tested using netperf (np3d test suite) on
local network. All tests passed.

Comment 33 Ben 2010-02-23 15:03:51 UTC
Update test status upon Snapshot1 and we are still verifying
Kernel: 2.6.18-187.el5
tg3: 3.106

1. Driver Load and Unload:
     Pass: 57760, 5722, 5723
2. Speed/Duplex and Flow control
     Pass: 57760, 57765
3. WOL
     Pass: 57760, 5722, 5723
4. IPv6 Checksum Offload
     Pass: 57765
5. UDP Performance Test Using Netperf
     Pass: 57765 / 57760 / 5722 /5723
6. Continuous reboot test
     Pass: 57760, 5722, 5723
7. iSCSI Storage Data Verification Stress Test / iSCSI boot DVD Installation
     Pass: 57765
8: LED Test:
     Pass: 57760, 5722, 5723
     Fail: 57765 (LED off when link at 100M)

Comment 34 Andrius Benokraitis 2010-02-23 15:10:34 UTC
LED fix is targeted for Snapshot 3. Please test Snap 3 when it is released.

Comment 35 Jeff Leu 2010-03-04 10:31:37 UTC
Created attachment 397778 [details]
Install RH5.5 x86 snapshot 3 error

Comment 36 Andrius Benokraitis 2010-03-04 15:31:18 UTC
Probably need to wait for Snap 4...

https://bugzilla.redhat.com/show_bug.cgi?id=565964

Comment 38 IBM Bug Proxy 2010-03-29 21:42:55 UTC
------- Comment From coschult.com 2010-03-29 17:34 EDT-------
I re-ran my tests on RC2. All tests passed.

( I used a Broadcom 5721 PCIe adapter. Driver present after booting and card detected. Tested using netperf (np3d test suite) on local network. )

Comment 39 errata-xmlrpc 2010-03-30 07:17:22 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.