Spec Url: http://dvisvgm.sourceforge.net/fedora/cxxtest.spec SRPM Url: http://dvisvgm.sourceforge.net/fedora/cxxtest-3.10.1-1.fc11.src.rpm Description: cxxtest is a JUnit-like testing framework for C++. Its advantages over existing alternatives are that it: - doesn't require RTTI - doesn't require member template functions - doesn't require exception handling - doesn't require any external libraries (including memory management, file/console I/O, graphics libraries) % rpmlint RPMS/noarch/cxxtest-* cxxtest-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. % rpmlint SRPMS/cxxtest-3.10.1-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- There's no need to Requires: python, RPM picks it up automatically. Drop it. - The package contains python parts, so it's best to BuildRequires: python-devel. Extract from build log: + exit 0 /usr/lib/rpm/pythondeps.sh: line 8: python: command not found /usr/lib/rpm/pythondeps.sh: line 8: python: command not found ** As this is inherently a development package, I think the headers should go into the main package. The split is OK if you can use the files in the main package without the -devel package being installed. ** rpmlint output: cxxtest-devel.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 1 warnings. This is expected. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK - To be clearer I recommend changing %{_includedir}/* to %{_includedir}/cxxtest/ MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK - Source code contains no headers. - README states cxxtest is under LGPL (no version stated), thus license tag is LPGLv2+. (Since there was no LGPLv2; in case of GPL this would be GPL+.) MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. ? - This is a development package, so the headers should probably be in the main package. MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK
Spec Url: http://dvisvgm.sourceforge.net/fedora/cxxtest.spec SRPM Url: http://dvisvgm.sourceforge.net/fedora/cxxtest-3.10.1-2.fc11.src.rpm Thanks for the review. Your annotations have been applied.
$ rpmlint cxxtest-* cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/SelfTest.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/YesNoRunner.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/RealDescriptions.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/RealDescriptions.cpp cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/Mock.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/DummyDescriptions.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/GlobalFixture.cpp cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/ErrorPrinter.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/Gui.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/LinkedList.cpp cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/GlobalFixture.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/TestSuite.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/TestListener.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/StdioPrinter.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/StdioFilePrinter.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/ParenPrinter.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/X11Gui.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/LinkedList.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/DummyDescriptions.cpp cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/Win32Gui.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/TeeListener.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/StdValueTraits.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/Root.cpp cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/Flags.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/ValueTraits.cpp cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/TestTracker.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/TestTracker.cpp cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/TestRunner.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/Descriptions.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/TestSuite.cpp cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/QtGui.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/ErrorFormatter.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/ValueTraits.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/StdHeaders.h cxxtest.noarch: W: devel-file-in-non-devel-package /usr/include/cxxtest/Descriptions.cpp 3 packages and 0 specfiles checked; 0 errors, 35 warnings. Once again, these don't have to be cared about, as this is a development package. ** The package has been APPROVED. ** PS. If you're going to build for F-10 or EPEL, you need to remove the Python bytecode files in %{_bindir} by either %if 0%{?fedora}<11 || 0%{?rhel} == 4 || 0%{?rhel} == 5 %exclude %{_bindir}/*.pyc %exclude %{_bindir}/*.pyo %endif in %files, or %if 0%{?fedora}<11 || 0%{?rhel} == 4 || 0%{?rhel} == 5 rm $RPM_BUILD_ROOT%{_bindir}/*.py{o,c} %endif at the end of %install.
Thanks for the information and your help. I will add the above code to be more compatible.
Spec Url: http://dvisvgm.sourceforge.net/fedora/cxxtest.spec SRPM Url: http://dvisvgm.sourceforge.net/fedora/cxxtest-3.10.1-3.fc11.src.rpm I've added the conditional removal of python object files as suggested in comment #3. The package builds in mock. Do I need another approval before setting the cvs flag?
No, nothing important has changed. That's normal package maintenance that you are able to do yourself.
New Package CVS Request ======================= Package Name: cxxtest Short Description: A JUnit-like testing framework for C++ Owners: mgieseki Branches: F-10 F-11 EL-5 InitialCC:
CVS done.
Martin: the assignee in reviews is the reviewer.
Yes, sorry. It was a mistake. I was looking for the button to close the bug and thought I must be the owner of this ticket to do so. But then I recognized the Edit link beside the "Status" tag...
OK. You don't have to close the bug yourself, you just fill in the bug number when you submit the update. The bug(s) are automatically closed when the update hits the (stable) updates repository.
Ah, ok. I closed it manually because it's suggested in step 13 on page http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess
cxxtest-3.10.1-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
cxxtest-3.10.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: cxxtest New Branches: epel7 Owners: mgieseki InitialCC:
Git done (by process-git-requests).