Bug 515531 - Review Request: constantine-backgrounds - Constantine desktop backgrounds
Summary: Review Request: constantine-backgrounds - Constantine desktop backgrounds
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ian Weller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-04 17:02 UTC by Martin Sourada
Modified: 2010-02-17 21:12 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-17 21:12:20 UTC
Type: ---
Embargoed:
ian: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Martin Sourada 2009-08-04 17:02:33 UTC
Spec URL: http://mso.fedorapeople.org/packages/SPECS/constantine-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/constantine-backgrounds-11.90.0-1.fc11.src.rpm
Description: Set of wallpapers we (design-team) are preparing for F12 Constantine.

Comment 1 Martin Sourada 2009-08-04 17:24:10 UTC
Looks like I left F11_Artwork in the URL instead of F12_Artwork... I'll change it together with source url when I finish to upload it on fedorahosted.

Comment 2 Martin Sourada 2009-08-04 17:32:55 UTC
Uploaded and changed.
New SPEC URL: http://mso.fedorapeople.org/packages/SPECS/constantine-backgrounds.spec
I think re-uploading SRPM is not necessary, as the change is only cosmetic (and 24MB is rather a lot).

Comment 3 Ian Weller 2009-08-04 17:35:52 UTC
I'll take this.

Comment 4 Ian Weller 2009-08-04 18:12:10 UTC
[  OK  ] source files match upstream:
  fb004429dbd5ba53b8e0cef379d5ea23  constantine-backgrounds-11.90.0.tar.lzma
  fb004429dbd5ba53b8e0cef379d5ea23  constantine-backgrounds-11.90.0.tar.lzma.1
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  N/A ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[      ] package builds in mock.
[  OK  ] package installs properly.
[  N/A ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
[  OK  ] final provides and requires are sane
  constantine-backgrounds = 11.90.0-2.fc11
  constantine-backgrounds-extras = 11.90.0-2.fc11
[  N/A ] %check is present and all tests pass:
[  OK  ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[FAILED] doesn't own any directories it shouldn't.
  Both the main package and the subpackage own
  /usr/share/backgrounds/constantine. 
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  N/A ] desktop files valid and installed properly.

Comment 5 Ian Weller 2009-08-04 18:12:51 UTC
(In reply to comment #4)
> [      ] package builds in mock.

Still building this in mock, will post the result shortly.

Comment 6 Ian Weller 2009-08-04 18:56:00 UTC
Mock build [  OK  ]

Comment 7 Martin Sourada 2009-08-04 19:23:03 UTC
(In reply to comment #4)
> [FAILED] doesn't own any directories it shouldn't.
The packages can be installed independently so it should be OK to own the dir by both, alternative would be to create another sub-package owning the directory and have both packages require it.

Comment 8 Martin Sourada 2009-08-04 19:26:56 UTC
(In reply to comment #7)
> (In reply to comment #4)
> > [FAILED] doesn't own any directories it shouldn't.
> The packages can be installed independently so it should be OK to own the dir
> by both, alternative would be to create another sub-package owning the
> directory and have both packages require it.  

The case I'm referring to is 2) in
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership

Comment 9 Ian Weller 2009-08-04 19:29:42 UTC
Oh. :)

------------------------------------------------------------------------
  This package (constantine-backgrounds) is APPROVED by me (ianweller)
------------------------------------------------------------------------

Comment 10 Martin Sourada 2009-08-04 19:32:59 UTC
New Package CVS Request
=======================
Package Name: constantine-backgrounds
Short Description: Constantine desktop backgrounds
Owners: mso
Branches: 
InitialCC:

Comment 11 Jason Tibbitts 2009-08-04 20:32:14 UTC
CVS done.

Comment 12 Paul W. Frields 2010-02-17 21:07:23 UTC
This bug needs to be closed.  Given the late hour, should it be RAWHIDE or CURRENTRELEASE? :-)

Comment 13 Martin Sourada 2010-02-17 21:12:20 UTC
Darn, I don't know how it happened I forgot to close it... Anyway. Given that it has been practically closed during F12 rawhide, I think RAWHIDE is better resolution...


Note You need to log in before you can comment on or make changes to this bug.