Bug 515589 - dracut's plymouth install doesn't look right.
Summary: dracut's plymouth install doesn't look right.
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: dracut
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Harald Hoyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F12Beta, F12BetaBlocker
TreeView+ depends on / blocked
 
Reported: 2009-08-04 20:30 UTC by Ray Strode [halfline]
Modified: 2013-01-10 05:19 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
: 520515 (view as bug list)
Environment:
Last Closed: 2009-09-10 08:45:24 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
The grubby/new-kernel-package bits (25.66 KB, patch)
2009-09-08 20:52 UTC, Ray Strode [halfline]
no flags Details | Diff

Description Ray Strode [halfline] 2009-08-04 20:30:31 UTC
It ends up installing the label.so control plugin which isn't supposed to get installed into the initrd.  this makes cairo and libX11 and all sorts of things move into the initrd that aren't supposed to.

Looking 50plymouth I see a plymouth-populate-initrd that has some iffy logic:

if hostonly; then
  install just details text and the currently configured theme
else
  install every theme and plugin and set the default to text
fi

hostonly is about whether dracut should look at the currently running /hardware/ not the currently configured plymouth splash.

It should always use the currently configured plymouth splash, even in generic mode.

Also, any particular reason it doesn't just use the plymouth-populate-initrd that comes with plymouth?

Comment 1 Harald Hoyer 2009-08-05 08:35:19 UTC
> It should always use the currently configured plymouth splash, even in generic
> mode.

and what is configured on a koji build of the kernel?? That does not makes sense for the initrd-generic-$(uname -r).img which is build in the kernel rpm.

Comment 2 Ray Strode [halfline] 2009-08-05 15:35:50 UTC
we're building initrd at build time now instead of install time?

Comment 3 Warren Togami 2009-08-05 15:45:50 UTC
> hostonly is about whether dracut should look at the currently running
> /hardware/ not the currently configured plymouth splash.
> It should always use the currently configured plymouth splash, even in generic
mode.

+1 exactly right

Comment 4 Harald Hoyer 2009-08-06 10:22:25 UTC
Warren? How is that supposed to work in koji???

Comment 5 Ray Strode [halfline] 2009-08-06 14:25:40 UTC
I still don't know the answer to comment 2.

If the answer is yes, and we aren't ever rebuilding the initrd then we need to ship every plymouth splash with all images into the initrd (which will make it very large).

Also, we'll need to fix plymouth to read what splash to use from the kernel command line instead of the filesystem.

And we'll need to fix something to update the kernel command line every time the default is changed.

Comment 6 Harald Hoyer 2009-08-06 14:46:43 UTC
yes, yes, yes

Comment 7 Harald Hoyer 2009-08-06 14:47:30 UTC
(In reply to comment #5)
> Also, we'll need to fix plymouth to read what splash to use from the kernel
> command line instead of the filesystem.
> 

the plymouth dracut module does that already and set the symlink

Comment 8 Bill Nottingham 2009-08-06 16:01:32 UTC
If we have a plymouth dracut module that does this, then plymouth should be part of the smaller initramfs, with only the specific bits.

Having to carry every possible plymouth splash plugin, background, logo set, etc. in the generic initramfs is just bad design.

Comment 9 Jesse Keating 2009-08-06 22:21:24 UTC
It doesn't appear that we're going to burn on booting dracut created initrds for F12 Alpha, ergo moving this off of the Alpha tracker.  Putting on Beta, given we might turn booting dracut on at that point.

Comment 10 Ray Strode [halfline] 2009-08-28 15:26:37 UTC
So I talked to harald about this today.

I think what we're going to do is

1) only ship a minimal plymouth install in the dracut initrd
2) have plymouth create its own initrd with the current configured theme and most up to date version of plymouth that's rebuilt in plymouth %post

We put both images on the initrd line in grub.conf so they work together.

This is basically what was proposed in comment 8 I think.

Comment 11 Ray Strode [halfline] 2009-08-29 15:42:03 UTC
The plymouth bits of this are in now:

http://koji.fedoraproject.org/koji/buildinfo?buildID=129759

So now we need dracut changed to only have details + minimal plymouth, and then have grubby changed to use multiple initrds on one line.

Comment 12 Ray Strode [halfline] 2009-09-08 20:52:29 UTC
Created attachment 360131 [details]
The grubby/new-kernel-package bits

This is a first cut at the grubby and new-kernel-package bits.  I've only tested it with grub, and only lightly there, so it may have bugs.

Comment 13 Ray Strode [halfline] 2009-09-09 15:40:04 UTC
I talked to Hans about this on IRC. We've decided to hold off doing separate plymouth initrd until F13, so it can get more testing.

dracut is going to get run during %post for now, also.

Comment 14 Hans de Goede 2009-09-10 08:45:24 UTC
This is fixed in dracut-001-9.git6f0e469d.fc12 + plymouth-0.7.1-4.fc12, which
will be in the next rawhide compose, closing.


Note You need to log in before you can comment on or make changes to this bug.