Description of problem: kvm compilation is too verbose at the moment. And it introduces lots of warnings. That makes seeing new warnings when testing/compiling bugs very difficult. In code inspection for 5.4, I found that one of the warnings was critical and another 3 not very good. The rest were false positives. This set of patches fixes all the remaining warnings, and make code inspection/bug fixing/introducing new features easier. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Created attachment 356335 [details] Use quiet command to have a cleaner command line
Created attachment 356336 [details] Remove unused function
Created attachment 356337 [details] Remove unused variable
Created attachment 356338 [details] Right argument number
Created attachment 356339 [details] Use right type uint8_t isntead of char
Created attachment 356340 [details] Use C99 function declaration, not K&R
Created attachment 356343 [details] Add missing static modifiers
Created attachment 356345 [details] Use only one declaration by extern variable
Created attachment 356347 [details] Don't redeclare external variable kvm_allowed
Created attachment 356348 [details] Put prototype in header
Created attachment 356349 [details] Mark another variable static
Created attachment 356350 [details] mp_state is uint32_t
Created attachment 356351 [details] More static functions
Created attachment 356352 [details] Use uint32_t instead of int
Created attachment 356353 [details] Use right type
Created attachment 356354 [details] Don't use reason parameter, that don't exist in our version
Created attachment 356355 [details] Remove unused variable
Created attachment 356356 [details] Another missing prototype
Created attachment 356357 [details] var used as uint32_t should be declared as that
Created attachment 356358 [details] Remove duplicated declaration
Created attachment 356359 [details] Remove unused variable
Created attachment 356360 [details] Make local variable static
Created attachment 356361 [details] Remove duplicated declaration
Created attachment 356362 [details] Initialize variable to make gcc happy
Created attachment 356363 [details] Use right modifier for time_t
Created attachment 356364 [details] Remove unused variable
Created attachment 356365 [details] Reset handlers have a different type
Created attachment 356366 [details] Right type nb_sectors
Created attachment 356368 [details] Initialize variable to make gcc happy
Created attachment 356369 [details] If you change variable types, you also have to change printf
Created attachment 356370 [details] Make local variable static
Created attachment 356371 [details] Remove unused variable
Created attachment 356372 [details] perror is defined in <stdio.h>
Created attachment 356373 [details] Remove duplicated declaration
Created attachment 356374 [details] Remove duplicated declaration
Created attachment 356375 [details] Add cast to silence warning
Created attachment 356376 [details] Compile qemu with -Werror
Created attachment 356378 [details] Move several variables after .h that declares them as extern
*** Bug 513255 has been marked as a duplicate of this bug. ***
*** Bug 513263 has been marked as a duplicate of this bug. ***
Not all warnings were fixed. More patches were posted on virtualist.
Ignore them, please. That are kvm only parts (not qemu ones) and they are not used anymore on upstream qemu/kvm (they are different). Thanks for all the tracking.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0271.html