Spec URL: http://hvad.cfppa-cibeins.com/perl-modules/perl-Config-Model-Itself/perl-Config-Model-Itself.spec SRPM URL: http://hvad.cfppa-cibeins.com/perl-modules/perl-Config-Model-Itself/perl-Config-Model-Itself-1.211-1.fc10.src.rpm Description: <description here>
This fails to build; it seems that it depends on another package which is in the review queue. You should set the ticket dependency fields appropriately so that we know the order in which the packages should be reviewed. Also, "<description here>"? Is it really so difficult to paste in the description?
(In reply to comment #0) > Spec URL: > http://hvad.cfppa-cibeins.com/perl-modules/perl-Config-Model-Itself/perl-Config-Model-Itself.spec > SRPM URL: > http://hvad.cfppa-cibeins.com/perl-modules/perl-Config-Model-Itself/perl-Config-Model-Itself-1.211-1.fc10.src.rpm > Description: The Config::Itself and its model files provide a model of Config:Model.
Hi, Spec URL: http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself.spec SRPM URL: http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself-1.215-1.fc12.src.rpm Description: The Config::Itself and its model files provide a model of Config:Model. Best regard
Taking.
Building in dist-f13 fails (looks like perl-Config-Model is too old). See http://koji.fedoraproject.org/koji/taskinfo?taskID=2347349 for more info. Building in mock rawhide fails due to Test::More not being a BR. David, please fix this.
Hi, The file was present on my machine but forgot to put it on bugzilla. Sorry for the delay Spec URL: http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself.spec SRPM URL: http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself-1.215-2.fc12.src.rpm Description: The Config::Itself and its model files provide a model of Config:Model. Best regard
- = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2505254 [x] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings. [x] Package is not relocatable. [x] Buildroot is correct %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: LGPLv2+ [!] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Config-Model-Itself contains a LICENSE file. This is not in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 03c034388e2ee583035b4708363b530e Config-Model-Itself-1.215.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [!] Latest version is packaged. Latest version is 1.218 . Please update your package if it's possible. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: rawhide.x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: rawhide.x86_64 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=7, Tests=52, 22 wallclock secs ( 0.03 usr 0.02 sys + 21.62 cusr 0.29 csys = 21.96 CPU) Result: PASS Add the LICENSE file to %doc, update your package to the latest version if you can and we're good to go.
Hi, I add LICENSE file to %doc and update package to latest version. Spec URL: http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself.spec SRPM URL: http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself-1.218-1.fc12.src.rpm Description: The Config::Itself and its model files provide a model of Config:Model. Best regard
(In reply to comment #8) > > SRPM URL: > http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself-1.218-1.fc12.src.rpm This gives me a 404 error. There's a srpm at http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself that has a 1.218-1 tag but the spec file in that srpm is different from the one you've given above. Please redo your upload. Emmanuel
Hi, I just changed the rights on the file. You can download the file to the url http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself-1.218-1.fc12.src.rpm. Sorry for the inconvenience. Best regard
This still leaves my second complaint. The spec file that you've linked to in comment #8 is not the one from the .src.rpm in comment #10. Please fix this.
Hi, New SRPM and Spec file. SRPM URL: http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself-1.222-1.fc14.src.rpm Spec URL: http://hvad.fedorapeople.org/fedora/perl-Config-Model-Itself/perl-Config-Model-Itself.spec Best regard
I did the review of your package shortly after you updated it and never submitted it into Bugzilla. Sorry, David. === KEY === - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3803638 [x] Rpmlint output: perl-Config-Model-Itself.noarch: E: incorrect-fsf-address /usr/share/doc/perl-Config-Model-Itself-1.222/LICENSE 2 packages and 1 specfiles checked; 1 error. Please file a bug upstream requesting the address be updated (assuming this hasn't been done since then). [x] Package is not relocatable. [x] Buildroot is correct Note that the Buildroot specified in the file is only used on EPEL5. If you don't care about this target, feel free to drop it. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: LGPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 24d1dc5ee6c23228f7b7235150bc818d Config-Model-Itself-1.222.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [!] Latest version is packaged. 1.228 is out. David, please update asap. [x] Package does not include license text files separate from upstream. [x] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: fedora-rawhide-x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3803638 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [!] %check is present and the tests pass Tests witch require a GUI. :-( APPROVED
New Package SCM Request ======================= Package Name: perl-Config-Model-Itself Short Description: Model editor for Config::Model Owners: hvad Branches: f16 InitialCC: perl-sig
Git done (by process-git-requests). Added f17.