Spec URL: http://fedorapeople.org/~iarnell/review/perl-Devel-LeakGuard-Object.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Devel-LeakGuard-Object-0.06-1.fc12.src.rpm Description: This module provides tracking of objects, for the purpose of detecting memory leaks due to circular references or innappropriate caching schemes. Additional Comment: build requires perl-latest (review at bug #516327) *rt-0.10
will do this review
perl-latest is there now, so scratch build available: https://koji.fedoraproject.org/koji/taskinfo?taskID=1598708
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1619853 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f9ca4403d02ecbe819a5f69fe4afcc0ab141398e Devel-LeakGuard-Object-0.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=60, 0 wallclock secs ( 0.03 usr 0.03 sys + 0.28 cusr 0.03 csys = 0.37 CPU) + Package perl-Devel-LeakGuard-Object-0.06-1.fc12.noarch => Provides: perl(Devel::LeakGuard::Object) = 0.06 perl(Devel::LeakGuard::Object::State) = 0.06 Requires: perl >= 0:5.008 perl(Carp) perl(Data::Dumper) perl(Devel::LeakGuard::Object) perl(Devel::LeakGuard::Object::State) perl(Devel::Peek) perl(List::Util) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) + Not a GUI application Suggestions: 1) license should be "GPLv2+ or artistic" as per LICENSE file APPROVED.
Strange - I hadn't noticed that LICENSE file contains the text of GPLv2. But there's also a little chunk at the head of LICENSE explaining the terms of Perl itself (i.e. GPL+ or Artistic) and the license in the code itself (Object.pm and State.pm) is also "same terms as Perl itself". I believe that means it really is only "GPL+ or Artistic" and that the GPLv2 license text is for information only.
New Package CVS Request ======================= Package Name: perl-Devel-LeakGuard-Object Short Description: Scoped checks for object leaks Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
CVS Done
perl-Devel-LeakGuard-Object-0.06-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Devel-LeakGuard-Object-0.06-1.fc11
perl-Devel-LeakGuard-Object-0.06-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Devel-LeakGuard-Object-0.06-1.fc10
perl-Devel-LeakGuard-Object-0.06-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Devel-LeakGuard-Object-0.06-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.