Red Hat Bugzilla – Bug 516528
Review Request: globus-gram-client-tools - Globus Toolkit - Job Management Tools (globusrun)
Last modified: 2010-03-11 22:40:40 EST
Spec URL: http://www.grid.tsl.uu.se/review/globus-gram-client-tools.spec
SRPM URL: http://www.grid.tsl.uu.se/review/globus-gram-client-tools-5.0-1.fc11.src.rpm
The Globus Toolkit is an open source software toolkit used for building Grid
systems and applications. It is being developed by the Globus Alliance and
many others all over the world. A growing number of projects and companies are
using the Globus Toolkit to unlock the potential of grids for their cause.
The globus-gram-client-tools package contains:
Job Management Tools (globusrun)
Globus Toolkit Packaging Guidelines:
Review updated for Globus Toolkit 5:
mainly just to keep rpmlint happy.
$ rpmlint globus-gram-client-tools.spec
globus-gram-client-tools.spec: W: invalid-url Source0: globus_gram_client_tools-7.3.tar.gz
Other than that looks trivial to approve.
New rpmlint version bringing new surprises.
The new rpmlint is not complaining about Source vs. Source0, your suggested "fix" does not resolve the issue rpmlint is complaining about.
I can make the warning go away by creating a dummy URL like:
But this seems to be a really stupid thing to do. The auto QA tests that download the sources and compares them with the ones in the look-aside cache will report errors for this, since the URL does not exist.
To me, this behaviour of the new rpmlint version doesn't make sense. I have submitted a bug report (bug #566978).
I agree, a dummy.org URL makes no sense at all.
I misinterpreted the results.
bug #566978 is completely valid. I guess what needs to worked on is
full URL for such a download/extract -> tar ball.
Will review in the morning.
This is a standard globus package where .spec has been
generated with scripts.
$ rpmlint rpmbuild/SPECS/globus-gram-client-tools.spec rpmbuild/SRPMS/globus-gram-client-tools-7.3-1.fc13.src.rpm rpmbuild/RPMS/x86_64/globus-gram-client-tools-*rpm
rpmbuild/SPECS/globus-gram-client-tools.spec: W: invalid-url Source0: globus_gram_client_tools-7.3.tar.gz
globus-gram-client-tools.src: W: spelling-error Summary(en_US) globusrun -> globulin, globular, globule
globus-gram-client-tools.src: W: spelling-error %description -l en_US globusrun -> globulin, globular, globule
globus-gram-client-tools.src: W: invalid-url Source0: globus_gram_client_tools-7.3.tar.gz
3 packages and 1 specfiles checked; 0 errors, 4 warnings.
which is all fine.
diff --brief -r rpmbuild/SOURCES/globus_gram_client_tools-7.3 \
Only in rpmbuild/SOURCES/globus_gram_client_tools-7.3: GLOBUS_LICENSE
which is expected.
Thank you for the review!
New Package CVS Request
Package Name: globus-gram-client-tools
Short Description: Globus Toolkit - Job Management Tools (globusrun)
Branches: F-11 F-12 F-13 EL-4 EL-5
CVS done (by process-cvs-requests.py).
globus-gram-client-tools-7.3-1.fc13 has been submitted as an update for Fedora 13.
globus-gram-client-tools-7.3-1.el5 has been submitted as an update for Fedora EPEL 5.
globus-gram-client-tools-7.3-1.el4 has been submitted as an update for Fedora EPEL 4.
globus-gram-client-tools-7.3-1.fc12 has been submitted as an update for Fedora 12.
globus-gram-client-tools-7.3-1.fc11 has been submitted as an update for Fedora 11.
globus-gram-client-tools-7.3-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
globus-gram-client-tools-7.3-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
globus-gram-client-tools-7.3-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
globus-gram-client-tools-7.3-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
globus-gram-client-tools-7.3-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.