Description of problem: During RHEL and oVirt VDSM installation/registration process, the API allows VDC to send configuration changes to the VDSM. IE- SSL=true, etc. The API consists of a key and a value, and the bootstrap script is doing search-replace in vdsm configuration file. If the given key is missing, it will not be updated as needed. We should add to the API the sction who owns the given key in the configuration file. In this way the bootstrap script will be able to add the given value to the file if it's not there.
Changed target release flag to 3.0? This issue needs to be handled.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion.
Re-assigning to Dan due to re-org.
why not deal with this like git-config does (section.name=value)? if section not found it creates it.
(In reply to comment #6) > why not deal with this like git-config does (section.name=value)? > if section not found it creates it. This is something the XXX_bootstrap_complete is doing, so Dan can choose how to implement it, and let us know what he needs from BE. Just remember to handle keys which include a '.'...
We're post feature freeze, postponing.
New bootstrap code overrides the vdsm.conf completely. No search and replace any more.
(In reply to comment #10) > New bootstrap code overrides the vdsm.conf completely. > No search and replace any more. Does it take arguments from the engine to be set in vdsm.conf? ie- can engine decide every new host will have ssl=false and ksm=false?
(In reply to comment #11) > (In reply to comment #10) > > New bootstrap code overrides the vdsm.conf completely. > > No search and replace any more. > > Does it take arguments from the engine to be set in vdsm.conf? > ie- can engine decide every new host will have ssl=false and ksm=false? Yes, you can override any vdsm parameter you like via engine. By adding to environment[1] a key/value at the following format: VDSM_CONFIG/vars/ssl=str:false I don't think ksm settings are currently supported by the engine. We can extend the engine to have some vdc_options of common options to send. [1] http://gerrit.ovirt.org/gitweb?p=ovirt-host-deploy.git;a=blob;f=README.environment#l50
In the past we had something like: {vdsInstaller} -c 'ssl={server_SSL_enabled};management_port={management_port}' which means we were able to add ';ksm=xxx' to handle it. So maybe you want to add it somewhere in the new implementation.
(In reply to comment #13) > In the past we had something like: > {vdsInstaller} -c > 'ssl={server_SSL_enabled};management_port={management_port}' > > which means we were able to add ';ksm=xxx' to handle it. > So maybe you want to add it somewhere in the new implementation. this required code change. as I wrote using code change you can push any variable.
Test: Add the following file at host: /etc/ovirt-host-deploy.conf.d/50-vdsm-params.conf --- [environment:init] VDSM_CONFIG/vars/ksm=str:on --- Expected, having ksm under [vars] with value on at vdsm.conf. In future engine may support this natively, taking these from its database...
sf 13.1. added /etc/ovirt-host-deploy.conf.d/50-vdsm-params.conf file with the [environment:init] VDSM_CONFIG/vars/ksm=str:on after installing host (bootstrap) vdsm.conf has ksm under vars.