Bug 516714 - Design bug in VDC-VDSM installation API - the way vdsm config params are communicated to the host
Summary: Design bug in VDC-VDSM installation API - the way vdsm config params are comm...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-host-deploy
Classification: oVirt
Component: Plugins.VDSM
Version: ---
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
: 1.0.0
Assignee: Alon Bar-Lev
QA Contact: Leonid Natapov
URL:
Whiteboard: infra
Depends On: bootstrap-rewrite
Blocks: 516716
TreeView+ depends on / blocked
 
Reported: 2009-08-11 09:18 UTC by Doron Fediuck
Modified: 2016-02-10 19:30 UTC (History)
11 users (show)

Fixed In Version: sf2
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-12 09:02:26 UTC
oVirt Team: Infra
Embargoed:
bazulay: devel_ack?


Attachments (Terms of Use)

Description Doron Fediuck 2009-08-11 09:18:09 UTC
Description of problem:
During RHEL and oVirt VDSM installation/registration process,
the API allows VDC to send configuration changes to the VDSM.
IE- SSL=true, etc. 
The API consists of a key and a value, and the bootstrap script
is doing search-replace in vdsm configuration file. If the given
key is missing, it will not be updated as needed.

We should add to the API the sction who owns the given key in
the configuration file. In this way the bootstrap script will be
able to add the given value to the file if it's not there.

Comment 1 Barak 2009-12-31 10:29:54 UTC
Changed target release flag to 3.0?
This issue needs to be handled.

Comment 3 RHEL Program Management 2010-06-07 16:12:32 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 4 Doron Fediuck 2011-01-24 09:43:33 UTC
Re-assigning to Dan due to re-org.

Comment 6 Itamar Heim 2011-11-15 21:58:20 UTC
why not deal with this like git-config does (section.name=value)?
if section not found it creates it.

Comment 7 Doron Fediuck 2011-11-16 08:38:24 UTC
(In reply to comment #6)
> why not deal with this like git-config does (section.name=value)?
> if section not found it creates it.

This is something the XXX_bootstrap_complete is doing, so Dan can choose how to implement it, and let us know what he needs from BE. Just remember to handle keys which include a '.'...

Comment 9 Ayal Baron 2012-04-04 14:42:57 UTC
We're post feature freeze, postponing.

Comment 10 Alon Bar-Lev 2012-11-28 08:30:05 UTC
New bootstrap code overrides the vdsm.conf completely.
No search and replace any more.

Comment 11 Doron Fediuck 2012-11-28 11:54:16 UTC
(In reply to comment #10)
> New bootstrap code overrides the vdsm.conf completely.
> No search and replace any more.

Does it take arguments from the engine to be set in vdsm.conf?
ie- can engine decide every new host will have ssl=false and ksm=false?

Comment 12 Alon Bar-Lev 2012-11-28 12:06:00 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > New bootstrap code overrides the vdsm.conf completely.
> > No search and replace any more.
> 
> Does it take arguments from the engine to be set in vdsm.conf?
> ie- can engine decide every new host will have ssl=false and ksm=false?

Yes, you can override any vdsm parameter you like via engine.

By adding to environment[1] a key/value at the following format:

VDSM_CONFIG/vars/ssl=str:false

I don't think ksm settings are currently supported by the engine. We can extend the engine to have some vdc_options of common options to send.

[1] http://gerrit.ovirt.org/gitweb?p=ovirt-host-deploy.git;a=blob;f=README.environment#l50

Comment 13 Doron Fediuck 2012-11-28 15:07:12 UTC
In the past we had something like:
{vdsInstaller} -c 'ssl={server_SSL_enabled};management_port={management_port}'

which means we were able to add ';ksm=xxx' to handle it.
So maybe you want to add it somewhere in the new implementation.

Comment 14 Alon Bar-Lev 2012-11-28 15:10:10 UTC
(In reply to comment #13)
> In the past we had something like:
> {vdsInstaller} -c
> 'ssl={server_SSL_enabled};management_port={management_port}'
> 
> which means we were able to add ';ksm=xxx' to handle it.
> So maybe you want to add it somewhere in the new implementation.

this required code change.
as I wrote using code change you can push any variable.

Comment 16 Alon Bar-Lev 2013-04-21 09:13:10 UTC
Test:

Add the following file at host:

/etc/ovirt-host-deploy.conf.d/50-vdsm-params.conf
---
[environment:init]
VDSM_CONFIG/vars/ksm=str:on
---

Expected, having ksm under [vars] with value on at vdsm.conf.

In future engine may support this natively, taking these from its database...

Comment 17 Leonid Natapov 2013-04-23 09:03:20 UTC
sf 13.1. added /etc/ovirt-host-deploy.conf.d/50-vdsm-params.conf file with the 
[environment:init]
VDSM_CONFIG/vars/ksm=str:on

after installing host (bootstrap)  vdsm.conf has ksm under vars.


Note You need to log in before you can comment on or make changes to this bug.