SPEC: http://www.package-review.xf.cz/irssi-xmpp.spec SRPM: http://package-review.xf.cz/irssi-xmpp-0.50-1.fc12.src.rpm PATCH: http://www.package-review.xf.cz/irssi-xmpp-0.50-config.patch Description: irssi-xmpp is an irssi plugin to connect to the Jabber network * Sending and receiving messages in irssi's query windows * A roster with contact & resource tracking (contact list) * Contact management (add, remove, manage subscriptions) * Tab completion of commands, JIDs and resources * Many extensions supported (XEP) including Multi-User Chat (MUC) * Support for multiple accounts * Unicode support (UTF-8) * SSL support * ...
$ rpmlint irssi-xmpp.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. FYI (not mandatory), you could use marcos like %__rm and %__make to replace rm and make.
mock failed: DEBUG util.py:256: ################################################## DEBUG util.py:256: error: unpacking of archive failed on file /builddir/build/SOURCES/irssi-xmpp-0.50.tar.gz;4a84c470: cpio: read failed - Invalid argument DEBUG util.py:256: error: /builddir/build/originals/irssi-xmpp-0.50-1.fc12.src.rpm cannot be installed DEBUG util.py:319: Child returncode was: 1
SPEC: http://www.package-review.xf.cz/irssi-xmpp.spec SRPM: http://package-review.xf.cz/irssi-xmpp-0.50-1.fc12.src.rpm Now without patch. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1609791 I hope it's enough.
You need to increment you spec file version when ever you make a change to it.
I thought that's not needed in initial build. Because there will be written only my mistakes when I tried to make new package.
SPEC: http://www.package-review.xf.cz/irssi-xmpp.spec SRPM: http://package-review.xf.cz/irssi-xmpp-0.50-2.fc12.src.rpm changes were written in spec and incremented version.
I built the rpm and srpm, then $ rpmlint SRPMS/irssi-xmpp-0.50-2.fc12.src.rpm RPMS/x86_64/irssi-xmpp-0.50-2.fc12.x86_64.rpm irssi-xmpp.x86_64: E: zero-length /usr/share/doc/irssi-xmpp-0.50/help/roster irssi-xmpp.x86_64: E: zero-length /usr/share/doc/irssi-xmpp-0.50/help/presence 2 packages and 0 specfiles checked; 2 errors, 0 warnings.
- Description has no full stop. Other then that it looks ok to me. Please look for a sponsor as this is a new package.
I will fix full stop when it will come to cvs. Please give me fedora‑review+
I got no power to approve new package. Let's get things fix so we could grab a sponsor to give you the flag. :)
I don't need sponsor, because I am already maintainer of many packages ;)
Thanks very much. Set flag.
New Package CVS Request ======================= Package Name: irssi-xmpp Short Description: irssi-xmpp is an irssi plugin to connect to the Jabber network Owners: npajkovs Branches: F-14 InitialCC:
This ticket is not assigned to anyone. It should be assigned to the reviewer. Please fix and re-set the fedora-cvs flag.
Hi npajkovs, when you request cvs you should set flag to '?' instead of '+'. (In reply to comment #14) > This ticket is not assigned to anyone. It should be assigned to the reviewer. > Please fix and re-set the fedora-cvs flag. I am the reviewer assignee. Please kindly create cvs for Nikola. Thank you very much.
This package has a few issues left: - It doesn't seem to use the standard fedora CFLAGS - You should include COPYING README NEWS TODO as doc files. - This builds here on f12, but not on devel/rawhide. - The source0 url is invalid here. Gives a 404: not found.
Clearing the fedora-cvs flag since this review still has a ways to go yet.
Oki, I've made a new build for f14 and fix Kevin's suggestion. spec: http://npajkovs.fedorapeople.org/irssi-xmpp.spec srpm: http://npajkovs.fedorapeople.org/irssi-xmpp-0.50-3.fc14.src.rpm
Thanks Nikola. CVS done (by process-cvs-requests.py). We aren't doing F-14 branches yet, so I just did devel here. If you need other branches, please add a template and set the fedora-cvs flag again.
Thanks Kevin, no that's fine like you did ;)