Spec URL: http://ruben.fedorapeople.org/perl-Nagios-Plugin.spec SRPM URL: http://ruben.fedorapeople.org/perl-Nagios-Plugin-0.33-1.fc11.src.rpm Description: Nagios::Plugin and its associated Nagios::Plugin::* modules are a family of perl modules to streamline writing Nagios plugins. The main end user modules are Nagios::Plugin, providing an object-oriented interface to the entire Nagios::Plugin::* collection, and Nagios::Plugin::Functions, providing a simpler functional interface to a useful subset of the available functionality.
Package doesn't build: ... ERROR: Bad build req: No Package Found for perl(Math::Calc::Units). ... These 2 requires probaly are unneccessary: ... Requires: perl(Class::Accessor) Requires: perl(Config::Tiny) ... However, as this package currently doesn't build, it's hard to verify if they really are required.
Hi Ralf, Hmm, I might have been bitten by the freeze, perl-Math-Calc-Units for f-11 is in updates-testing now but hasn't been pushed to rawhide yet. Those 2 Requires: Requires: perl(Class::Accessor) Requires: perl(Config::Tiny) are necessary, they're not automatically picked up by rpm and the package doesn't work without them.
Review: + package builds in koji (dist-f12). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1631629 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7f5e00a3d683b1d39b169d9d772de33b Nagios-Plugin-0.33.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=16, Tests=969, 6 wallclock secs ( 0.29 usr 0.02 sys + 5.01 cusr 0.17 csys = 5.49 CPU) Result: PASS + Package perl-Nagios-Plugin-0.33-1.fc12.noarch => Provides: perl(Nagios::Plugin) = 0.33 perl(Nagios::Plugin::Config) perl(Nagios::Plugin::ExitResult) perl(Nagios::Plugin::Functions) = 0.33 perl(Nagios::Plugin::Getopt) perl(Nagios::Plugin::Performance) perl(Nagios::Plugin::Range) perl(Nagios::Plugin::Threshold) Requires: perl(Carp) perl(Exporter) perl(File::Basename) perl(File::Spec) perl(Getopt::Long) perl(Math::Calc::Units) perl(Nagios::Plugin::Config) perl(Nagios::Plugin::Functions) perl(Nagios::Plugin::Range) perl(Nagios::Plugin::Threshold) Requires: perl(Carp) perl(Exporter) perl(File::Basename) perl(File::Spec) perl(Getopt::Long) perl(Math::Calc::Units) perl(Nagios::Plugin::Config) perl(Nagios::Plugin::Functions) perl(Nagios::Plugin::Range) perl(Nagios::Plugin::Threshold) perl(Params::Validate) perl(base) perl(constant) perl(overload) perl(strict) perl(vars) perl(warnings) + Not a GUI application Should: 1) License text is not included in package. This module does not contain the text of the licenses it is licensed under. Please contact upstream and encourage them to correct this mistake. APPROVED.
MISSING: R: perl(Class::Accessor::Fast) WRONG: R: perl(base)
(In reply to comment #4) > > MISSING: > R: perl(Class::Accessor::Fast) Correct. Ruben, please add "perl(Class::Accessor::Fast)". Like the other two, it's also used as a base module and we can't guarantee that it will always be provided by the rpm that provides "perl(Class::Accessor)". > WRONG: > R: perl(base) How so?
(In reply to comment #5) > (In reply to comment #4) > > WRONG: > > R: perl(base) > > How so? Sorry, scratch this remark - I was in error :(
(In reply to comment #6) > > Sorry, scratch this remark - I was in error :( No sweat, Ralf. Thanks for catching my mistake.
Ok, I've added perl(Class:Accessor::Fast), thanks for catching this. And thanks for the review, both of you. New Package CVS Request ======================= Package Name: perl-Nagios-Plugin Short Description: Family of perl modules to streamline writing Nagios plugins Owners: ruben Branches: F-11
Ruben, you need to ask the flag dedora-cvs (ie, make it fedora-cvs?, not fedora-cvs+). The CVS admin will put it to '+' when he has created the module.
While we're at it. Please add InitialCC: perl-sig to all "New Package CVS Requests" of perl-modules. TIA
I must have been sleepwalking :-) Let's try again. New Package CVS Request ======================= Package Name: perl-Nagios-Plugin Short Description: Family of perl modules to streamline writing Nagios plugins Owners: ruben Branches: F-11 InitialCC: perl-sig
CVS done.
perl-Nagios-Plugin-0.33-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Nagios-Plugin-0.33-2.fc11
perl-Nagios-Plugin-0.33-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Nagios-Plugin'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9172
Package Change Request ====================== Package Name: perl-Nagios-Plugin New Branches: EL-5 Owners: ruben jpo
cvs done.
perl-Nagios-Plugin-0.33-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: perl-Nagios-Plugin New Branches: EL-6 Owners: ruben jpo
An el6 branch of this package already exists.
Package Change Request ====================== Package Name: perl-Nagios-Plugin New Branches: EPEL-7 Owners: jpo
Git done (by process-git-requests).