Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec SRPM URL: http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-1.fc11.src.rpm Description: Doctrine is an object relational mapper (ORM) for PHP 5.2.3+ that sits on top of a powerful database abstraction layer (DBAL). One of its key features is the option to write database queries in a proprietary object oriented SQL dialect called Doctrine Query Language (DQL), inspired by Hibernates HQL. This provides developers with a powerful alternative to SQL that maintains flexibility without requiring unnecessary code duplication.
This is covered by multiple licenses (LGPLv2+,BSD,MIT) your spec should reflect that
(In reply to comment #1) > This is covered by multiple licenses (LGPLv2+,BSD,MIT) your spec should reflect > that You are right, I didn't see that. I uploaded new versions: Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec SRPM URL: http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-2.fc11.src.rpm I set it to: "LGPLv2 and MIT and BSD". I couldn't find any reference to LGPLv2+, but maybe I missed it.
A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include. Note that this is LGPLv2+, not LGPL+, because version 2 was the first version of LGPL. https://fedoraproject.org/wiki/Licensing
The LICENSE file contains: "GNU LESSER GENERAL PUBLIC LICENSE Version 2.1, February 1999" It doesn't state "or higher" as far as I can see.
Just read comment #3
(In reply to comment #5) > Just read comment #3 OK, changed to LGPLv2+ : Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec SRPM URL: http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-3.fc11.src.rpm
Provides: php-pear(doctrine/%{pear_name}) = %{version} Shouldn't that be: Provides: php-pear(pear.doctrine-project.com/%{pear_name}) = %{version} Looking at: https://fedoraproject.org/wiki/Packaging:PHP#PEAR_Packages_from_a_non_standard_channel.2Frepository
(In reply to comment #7) > Provides: php-pear(doctrine/%{pear_name}) = %{version} > > Shouldn't that be: > > Provides: php-pear(pear.doctrine-project.com/%{pear_name}) = %{version} That is fixed now: Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec SRPM URL: http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-4.fc11.src.rpm
Review ======= Good: - rpmlint checks return nothing - package meets naming guidelines (PHP) - package meets packaging guidelines (PHP) - license (LGPLv2+ and MIT and BSD) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (53d644dd56fbe58056ba33ff42a58482c86f330e92c9aceefdd86788171a1da2) - package compiles on devel (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED.
New Package CVS Request ======================= Package Name: php-doctrine-Doctrine Short Description: PHP Object Relational Mapper Owners: cdamian Branches: F-11 InitialCC:
cvs done.
php-doctrine-Doctrine-1.1.3-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-doctrine-Doctrine-1.1.3-4.fc11
php-doctrine-Doctrine-1.1.3-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-doctrine-Doctrine'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10014
php-doctrine-Doctrine-1.1.3-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: php-doctrine-Doctrine New Branches: F-12 Owners: cdamian
Hmm, what do you want? The F-12 branch should be created automatically. At http://cvs.fedora.redhat.com/viewvc/F-12/php-doctrine-Doctrine/ there is already one. Maybe you forgot a 'cvs update'?
I did, but I am an idiot anyway. I should have done "cvs update -dP" cheers
(In reply to comment #16) > The F-12 branch should be created automatically. No, now we are already past mass branching and it's F-13 that is created automatically.
(In reply to comment #18) > (In reply to comment #16) > > > The F-12 branch should be created automatically. > > No, now we are already past mass branching and it's F-13 that is created > automatically. Ok, adding 'have been'. -> The F-12 branch should 'have been' created automatically.
Package Change Request ====================== Package Name: php-doctrine-Doctrine New Branches: EL-6 Owners: cdamian
CVS done (by process-cvs-requests.py).