Spec URL: http://paragn.fedorapeople.org/hyphen-bn.spec SRPM URL: http://paragn.fedorapeople.org/hyphen-bn-0.20090813-1.fc11.src.rpm Description: Bengali hyphenation rules
Review: + package builds in mock + rpmlint is error-free for SRPM and for RPM. + source files match upstream url + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED. Are these hyphenation rules good for Bengali as written in Bangladesh ?, I'd guess that they probably are, if so then maybe... pushd $RPM_BUILD_ROOT/%{_datadir}/hyphen/ bn_IN_aliases="bn_BD" for lang in $bn_IN_aliases; do ln -s hyph_bn_IN.dic hyph_$lang.dic done popd after the cp is indicated
Thanks for the review. I will ask upstream and if they says its ok I will add support for bn_BD. New Package CVS Request ======================= Package Name: hyphen-bn Short Description: Bengali hyphenation rules Owners: pnemade Branches: F-11, devel InitialCC: pnemade
CVS done. You don't have to request a devel branch, you know.
Built for all requested branches with bn_BD support.