Bug 517822 - Review Request: hyphen-mr - Marathi hyphenation rules
Summary: Review Request: hyphen-mr - Marathi hyphenation rules
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-17 11:13 UTC by Parag Nemade
Modified: 2009-08-20 06:58 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-20 06:58:51 UTC
Type: ---
Embargoed:
caolanm: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Parag Nemade 2009-08-17 11:13:46 UTC
Spec URL: http://paragn.fedorapeople.org/hyphen-mr.spec   
SRPM URL: http://paragn.fedorapeople.org/hyphen-mr-0.20090813-1.fc11.src.rpm 
Description:  Marathi hyphenation rules.

Comment 1 Caolan McNamara 2009-08-19 07:28:08 UTC
Review:
+ package builds in mock
+ rpmlint is error-free for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 2 Parag Nemade 2009-08-19 08:45:26 UTC
Thanks for the review.

New Package CVS Request
=======================
Package Name: hyphen-mr
Short Description: Marathi hyphenation rules
Owners: pnemade
Branches: F-11, devel
InitialCC: pnemade

Comment 3 Jason Tibbitts 2009-08-19 21:20:55 UTC
CVS done.

Comment 4 Parag Nemade 2009-08-20 06:58:51 UTC
Built for all requested branches.


Note You need to log in before you can comment on or make changes to this bug.