Hide Forgot
Spec URL: http://overholt.fedorapeople.org/aqute-bndlib.spec SRPM URL: http://overholt.fedorapeople.org/aqute-bndlib-0.0.203-4.2.fc12.src.rpm Description: The bnd tool helps you create and diagnose OSGi R4 bundles. The key functions are: - Show the manifest and JAR contents of a bundle - Wrap a JAR so that it becomes a bundle - Create a Bundle from a specification and a class path - Verify the validity of the manifest entries The tool is capable of acting as: - Command line tool - File format - Directives - Use of macros
This is a full review request. The pre-review request was bug #500245.
I'll take this one.
Rpmlint gives a number of warnings: rpmlint aqute-bndlib.spec aqute-bndlib.spec:37: W: non-standard-group Development/Java aqute-bndlib.spec:72: W: non-standard-group Development/Documentation rpmlint aqute-bndlib-0.0.203-4.2.fc12.src.rpm aqute-bndlib.src: W: non-standard-group Development/Java rpmlint noarch/aqute-bndlib-* aqute-bndlib.noarch: W: non-standard-group Development/Java aqute-bndlib.noarch: W: incoherent-version-in-changelog 0.0.203-4.2 ['0:0.0.203-4.2.fc12', '0:0.0.203-4.2'] aqute-bndlib.noarch: W: no-documentation aqute-bndlib.noarch: W: non-conffile-in-etc /etc/maven/fragments/aqute-bndlib aqute-bndlib-javadoc.noarch: W: non-standard-group Development/Documentation I would like to see them (except non-conffile-in-etc) cleaned. Full review will follow shortly.
Updated package: http://overholt.fedorapeople.org/aqute-bndlib-0.0.203-4.3.fc12.src.rpm http://overholt.fedorapeople.org/aqute-bndlib.spec
Formal review: OK; rpmlint gives only non-conffile-in-etc OK; The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name} OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license OK: The License field in the package spec file must match the actual license. OK: License bundled and marked as %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: Sources match upstream. OK: The package MUST successfully compile and build into binary rpms. OK: All build dependencies are listed in BuildRequires OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. OK: Each package must have a %clean section, which contains rm -rf %{buildroot} OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: All filenames in rpm packages must be valid UTF-8. Package is APPROVED.
New Package CVS Request ======================= Package Name: aqute-bndlib Short Description: The bnd tool helps you create and diagnose OSGi R4 bundles. Owners: overholt, akurtakov Branches: InitialCC:
Oops, I forgot that the pre-review had been passed and therefore there was already a CVS module.
Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128069