Bug 517977 - Review Request: synergy-plus - Mouse and keyboard sharing utility
Summary: Review Request: synergy-plus - Mouse and keyboard sharing utility
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Martin Gieseking
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-18 09:15 UTC by Matthias Saou
Modified: 2009-09-15 07:55 UTC (History)
3 users (show)

Fixed In Version: 1.3.4-3.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-15 07:53:44 UTC
Type: ---
Embargoed:
martin.gieseking: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Matthias Saou 2009-08-18 09:15:10 UTC
Spec URL: http://thias.fedorapeople.org/review/synergy-plus/synergy-plus.spec
SRPM URL: http://thias.fedorapeople.org/review/synergy-plus/synergy-plus-1.3.4-1.src.rpm
Description:
Synergy+ (synergy-plus) lets you easily share a single mouse and keyboard
between multiple computers with different operating systems, without special
hardware. All you need is a LAN connection. It's intended for users with
multiple computers, where each system uses its own display. It's a little
like having a 2nd or a 3rd desktop.
Synergy+ is a maintenance fork for implementing bug fixes to the original
Synergy, which hasn't received any source updates or new releases since 2006.

Comment 1 Martin Gieseking 2009-08-18 13:49:26 UTC
Hi Matthias,

this package looks pretty clean. koji scratch build is successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1612162

$ rpmlint /var/lib/mock/fedora-11-i386/result/*.rpm
synergy-plus-debuginfo.i586: W: spurious-executable-perm /usr/src/debug/synergy-plus-1.3.4/lib/base/CLog.cpp
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

You should set the file permissions of lib/base/CLog.cpp to 644.

I'll do the full review a bit later today.

Comment 2 Matthias Saou 2009-08-18 14:18:35 UTC
(In reply to comment #1)
> You should set the file permissions of lib/base/CLog.cpp to 644.
Done.

Note that I've just checked the current hg sources, and apparently the latest have changed quite a bit since 1.3.4. They've switched away from autotools for the build for instance, and the GUI seems to be included.

I think sticking with the released version for now is best, though it will mean major changes to the spec/build once the next version is out.

Comment 3 Martin Gieseking 2009-08-18 15:10:23 UTC
> Note that I've just checked the current hg sources, and apparently the latest
> have changed quite a bit since 1.3.4. They've switched away from autotools for
> the build for instance, and the GUI seems to be included.
> I think sticking with the released version for now is best, though it will mean
> major changes to the spec/build once the next version is out.  


OK, thanks for the information. I've checked out the sources from the hg repo and tried to build the binaries. It's quite easy. The whole build process can be done with
  if [ -f bin/hm.cfg ] 
    then ./hm.sh build
    else echo 1 | ./hm.sh build
  fi

Thus, it shouldn't be too complicated to adapt the spec file later. But I agree that it's currently better to stick with the official release.

Comment 4 Martin Gieseking 2009-08-18 18:20:38 UTC
Here comes the full review. :)

I'm not familiar with the Fedora policy concerning larger upstream changes that require substantial changes of the spec file. If the next release becomes officially available, you should clarify whether another review is needed. I guess, it's not.


$ rpmlint /var/lib/mock/fedora-11-i386/result/*.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.


---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
    acoording to the file comment headers license is GPLv2 only 

[+] MUST: The License field in the package spec file must match the actual license.
[+] MUST: The license file included with the tarball must be part of the %doc section
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL.
    md5 hash is 2c565afe5f920d363eef38dd97449b73

[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an architecture,...
    - builds on all supported architectures

[+] MUST: All build dependencies must be listed in BuildRequires
[.] MUST: The spec file MUST handle locales properly.
    - no locales

[.] MUST: Every binary RPM package (or subpackage) which stores shared library files...
    - no shared libraries

[.] MUST: If the package is designed to be relocatable,...
    - package not designed to be relocatable

[.] MUST: A package must own all directories that it creates.
    - does not create directories

[+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large documentation

[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
    - no header files

[.] MUST: Static libraries must be in a -static package.
    - no static libs

[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability).
    - no pkgconfig files

[.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),...
    - no shared libraries

[.] MUST: In the vast majority of cases, devel packages must require the base package
    - no -devel subpackage

[.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
    - no .la files

[.] MUST: Packages containing GUI applications must include a %{name}.desktop file.
    - no GUI

[+] MUST: Packages must not own files or directories already owned by other packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock

[+] SHOULD: The package should compile and build into binary rpms on all supported architectures.
    - builds on all supported architecture in koji

[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
    - no scriptlets used

Comment 5 Martin Gieseking 2009-08-18 18:21:25 UTC
Everything looks fine now. The package is APPROVED.

Comment 6 Matthias Saou 2009-09-12 18:00:55 UTC
New Package CVS Request
=======================
Package Name: synergy-plus
Short Description: Mouse and keyboard sharing utility
Owners: thias
Branches: F-10 F-11 EL-5 EL-4
InitialCC:

Comment 7 Kevin Fenzi 2009-09-14 04:58:42 UTC
cvs done.

Comment 8 Fedora Update System 2009-09-14 14:17:16 UTC
synergy-plus-1.3.4-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/synergy-plus-1.3.4-3.fc10

Comment 9 Fedora Update System 2009-09-14 14:17:21 UTC
synergy-plus-1.3.4-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/synergy-plus-1.3.4-3.fc11

Comment 10 Fedora Update System 2009-09-15 07:53:39 UTC
synergy-plus-1.3.4-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2009-09-15 07:55:38 UTC
synergy-plus-1.3.4-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.