Bug 518365 - Review Request: jakarta-commons-configuration - Commons Configuration Package
Summary: Review Request: jakarta-commons-configuration - Commons Configuration Package
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-20 05:13 UTC by Alexander Kurtakov
Modified: 2009-08-20 19:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-20 19:51:10 UTC
overholt: fedora-review+


Attachments (Terms of Use)

Description Alexander Kurtakov 2009-08-20 05:13:09 UTC
Spec URL: http://akurtakov.fedorapeople.org/jakarta-commons-configuration.spec
SRPM URL: http://akurtakov.fedorapeople.org/jakarta-commons-configuration-1.4-6.fc12.src.rpm
Description: Configuration is a project to provide a generic Configuration
interface and allow the source of the values to vary. It
provides easy typed access to single, as well as lists of
configuration values based on a 'key'.
Right now you can load properties from a simple properties
file, a properties file in a jar, an XML file, JNDI settings,
as well as use a mix different sources using a
ConfigurationFactory and CompositeConfiguration.
Custom configuration objects are very easy to create now
by just subclassing AbstractConfiguration. This works
similar to how AbstractList works.

Comment 1 Alexander Kurtakov 2009-08-20 05:14:59 UTC
This is a full review request.  The pre-review request was bug #500256.

Comment 2 Andrew Overholt 2009-08-20 15:59:28 UTC
OK naming
OK version
OK licensing
OK requires
OK source (md5sums match)
OK files
OK macros
OK changelog
OK sections (rm at beginning of install, clean present)

X Fix description:  add an "of" between "mix" and "different"
X get rid of post{,un} requires for javadoc
X use %{__sed} -i 's/\r//' instead of dos2unix

Comment 3 Alexander Kurtakov 2009-08-20 17:54:43 UTC
(In reply to comment #2)
> OK naming
> OK version
> OK licensing
> OK requires
> OK source (md5sums match)
> OK files
> OK macros
> OK changelog
> OK sections (rm at beginning of install, clean present)
> 
> X Fix description:  add an "of" between "mix" and "different"
Fixed.
> X get rid of post{,un} requires for javadoc
Fixed.
> X use %{__sed} -i 's/\r//' instead of dos2unix  
Fixed

New sources:
Spec URL: http://akurtakov.fedorapeople.org/jakarta-commons-configuration.spec
SRPM URL:
http://akurtakov.fedorapeople.org/jakarta-commons-configuration-1.4-7.fc12.src.rpm

Comment 4 Andrew Overholt 2009-08-20 18:03:28 UTC
Thanks.  Approved.

Comment 5 Alexander Kurtakov 2009-08-20 19:51:10 UTC
Built in rawhide.
http://koji.fedoraproject.org/koji/buildinfo?buildID=128120


Note You need to log in before you can comment on or make changes to this bug.