Bug 518422 - abrt silently starts when plugin is configured but not installed
Summary: abrt silently starts when plugin is configured but not installed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: abrt
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jiri Moskovcak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 518245 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-20 11:19 UTC by Michal Hlavinka
Modified: 2015-02-01 22:48 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-10 13:25:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michal Hlavinka 2009-08-20 11:19:03 UTC
Description of problem:
When abrt is configured some plugin, but the plugin is not installed, it starts anyway silently

Version-Release number of selected component (if applicable):
0.0.7.1-1

How reproducible:
always

Steps to Reproduce:
1.configure abrt to use logger plugin
2.make sure abrt-plugin-logger is not installed
3.service abrt restart

  
Actual results:
Starting abrt daemon:                  [  OK  ]

Expected results:
abrt should fail to start, some error messages are also expected

Additional info:

Comment 1 Denys Vlasenko 2009-08-21 10:16:40 UTC
 the problem here is two-fold:
 1. abrt fails to report some of initialization problems
  * abrt may fail (exit/crash) but user sees "Starting abrt daemon: [  OK  ]"
  * abrt may start but be not fully functional (some/all plugins not installed)
 2. We have too many .rpms:
  * users are easily confused what rpms they need
  * it's easy to install wrong set of rpms: so that abrt config says
    "load plugins foo, bar and baz", but only foo is installed
 with reduced number of rpms we may be able to eliminate most of these scenarios

Comment 2 Denys Vlasenko 2009-08-21 10:25:08 UTC
*** Bug 518245 has been marked as a duplicate of this bug. ***

Comment 3 Denys Vlasenko 2009-11-13 13:12:40 UTC
This bug is fixed now, right?

Comment 4 Michal Hlavinka 2009-11-13 13:35:24 UTC
(In reply to comment #3)
> This bug is fixed now, right?  

no, there is only (intentional?) ugly workaround with metapackage "install everything":

yum remove abrt-plugin-logger
...
Removing:
 abrt-plugin-logger
Removing for dependencies:
 abrt-desktop
 abrt-gui

-------------------------
If I try:
rpm -e abrt-plugin-logger --nodeps
service abrtd restart

> Stopping abrt daemon:  [  OK  ]
> Starting abrt daemon:  [  OK  ]

but logger is still configured:
# grep -i logger /etc/abrt/abrt.conf
EnabledPlugins = SQLite3, CCpp, Logger, Kerneloops, KerneloopsScanner, KerneloopsReporter, Bugzilla, Python
CCpp = Bugzilla, Logger
Python = Bugzilla, Logger

so I think it's not fixed

Comment 5 Jiri Moskovcak 2009-11-13 14:15:05 UTC
This is not a bug as the wrong plugin in config file is not a reason for abrt to not run, if the plugin is not essential.
  Adn as for the abrt-desktop - I agree it's not a Fedora way and should be turned into a group.

Jirka

Comment 6 Bug Zapper 2009-11-16 11:33:53 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 7 Michal Hlavinka 2009-11-16 20:54:06 UTC
(In reply to comment #5)
> This is not a bug as the wrong plugin in config file is not a reason

Why this is not a bug? If configuration is wrong (typo) or plugin is configured but not installed, user should be informed when starting abrt, not just hit by runtime error

Comment 8 Jiri Moskovcak 2009-11-18 10:22:37 UTC
As I said "it's not a reason for daemon to not run", but you're right, user should be informed about this, but how would you do that during boot? ABRT can write it into syslog, but user still probably wouldn't notice, maybe we can add a notice into gui, that some plugin is misconfigured.

Jirka

Comment 9 Michal Hlavinka 2009-11-18 12:08:32 UTC
(In reply to comment #8)
> As I said "it's not a reason for daemon to not run", but you're right, user
> should be informed about this, but how would you do that during boot? ABRT can
> write it into syslog, but user still probably wouldn't notice, maybe we can add
> a notice into gui, that some plugin is misconfigured.

1) default installation should "just work". If user has changed something in the configuration, it's his responsibility to check if it still works. He usually changes configuration file and do service xyz restart afterwards. This command should a)fail OR b)(at least) produce error message to both syslog and console

2) some notification in gui would be great, but not required for case the daemon does not start with wrong configuration, because notification for this (daemon is not running) already exists

Comment 10 Jiri Moskovcak 2009-11-18 13:24:00 UTC
> 1) default installation should "just work". If user has changed something in
> the configuration, it's his responsibility to check if it still works. He
> usually changes configuration file and do service xyz restart afterwards. This
> command should a)fail OR b)(at least) produce error message to both syslog and
> console
> 

The default install works now (all plugins mentioned in config file are installed by default)

> 2) some notification in gui would be great, but not required for case the
> daemon does not start with wrong configuration, because notification for this
> (daemon is not running) already exists  

This warning is removed on request of users.

Jirka

Comment 11 Denys Vlasenko 2009-12-02 15:24:32 UTC
Committed a fix to git. Now abrtd will refuse to start if a required plugin is missing, with these messages in syslog:

Dec  2 16:23:09 abrtd: Can't initialize plugin RunApp: no such plugin installed
Dec  2 16:23:09 abrtd: Error while initializing daemon

Fix will be in the next update after abrt-1.0.0

Comment 12 Fedora Update System 2009-12-08 18:49:01 UTC
abrt-1.0.1-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/abrt-1.0.1-1.fc12

Comment 13 Fedora Update System 2009-12-10 04:20:48 UTC
abrt-1.0.1-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update abrt'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12994

Comment 14 Nikola Pajkovsky 2010-02-10 13:25:58 UTC
we have abrt-1.0.6 right now.


Note You need to log in before you can comment on or make changes to this bug.