Spec URL: http://overholt.fedorapeople.org/maven2-plugin-shade.spec SRPM URL: http://overholt.fedorapeople.org/maven2-plugin-shade-1.0-5.fc11.src.rpm Description: This plugin provides the capability to package the artifact in an uber-jar, including its dependencies and to shade - i.e. rename - the packages of some of the dependencies. This is a regular full review request. The old pre-review request was bug #500261.
Review Comments: 1. There is a BSD license at the top of the spec. Should the licensing add "and BSD"? 2. The description for the javadoc sub-package should be: This package contains the API documentation for %{name}. The template has its group as Development/Documentation, not Documentation. 3. The Java packaging guidelines state that there should be: Requires: jpackage-utils 4. The following sections from the maven template of the Java guidelines are missing. %post %update_maven_depmap %postun %update_maven_depmap
(In reply to comment #1) > 1. There is a BSD license at the top of the spec. Should the licensing > add "and BSD"? The License field is for the contents of the package, not the .spec. > 2. The description for the javadoc sub-package should be: > > This package contains the API documentation for %{name}. Done. > The template has its group as Development/Documentation, not Documentation. That makes rpmlint whine. > 3. The Java packaging guidelines state that there should be: > > Requires: jpackage-utils Fixed. > 4. The following sections from the maven template of the Java > guidelines are missing. > > %post > %update_maven_depmap > > %postun > %update_maven_depmap Oops :) Fixed. http://overholt.fedorapeople.org/maven2-plugin-shade.spec http://overholt.fedorapeople.org/maven2-plugin-shade-1.0-6.fc11.src.rpm P.S. I think you're supposed to set the fedora-review flag to '?' while you're reviewing it.
Thanks for addressing the comments. I have set the Fedora-review flag. Package approval waiting on build of package.
Now that maven2 is built in rawhide, you can probably just: yum --enablerepo=rawhide update maven2 and then build this package. Here's the latest .spec and .src.rpm: http://overholt.fedorapeople.org/maven2-plugin-shade.spec http://overholt.fedorapeople.org/maven2-plugin-shade-1.0-7.fc11.src.rpm
Here's a fixed maven2: http://koji.fedoraproject.org/koji/buildinfo?buildID=130018 It isn't yet in the yum repos, but manually downloading the RPMs and then using yum localinstall should work.
Build successful. Approved.
New Package CVS Request ======================= Package Name: maven2-plugin-shade Short Description: Maven Shade Plugin Owners: overholt, akurtakov Branches: InitialCC:
CVS done.
Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=130078