1. Feature Overview:
a. Name of feature: Update RHEL 5.4.z with enic version 1.1.0.x
b. Feature Description
Bug fixes/enhancements for enic driver update. Itemized list to be provided later (but not too much later).
2. Feature Details:
64-bit Intel EM64T/AMD64
b. Red Hat Bugzilla Dependencies: none
c. Drivers or hardware dependencies:
d. Upstream acceptance information: Planning on submitting early week of 8/31/09 to netdev
e. External links:
f. Severity (U,H,M,L):
High (required for Hardware Enablement)
g. Target Release Date: RHEL 5.4.z errata kernel
3. Business Justification:
a. Why is this feature needed? Hardware support, for (see b.)
b. What hardware does this enable? Cisco 10G Ethernet NIC
c. Forecast, impact on revenue? Cisco USC enablement.
d. Any configuration info?
e. Are there other dependencies (drivers).
4. Primary contact at Red Hat, email, phone (chat)
5. Primary contact at Partner, email, phone (chat)
Scott - this is for updating RHEL 5.5, not 5.4.z. Sorry if I had you misunderstood. Thanks!
Patches where submitted to netdev maintainer and accepted into net-next. These patches will need to be back-ported to the RHEL 5.5 kernel. The driver version is 126.96.36.199. The patches are here:
Please apply to RHEL 5.5 (and RHEL 5.4z. errata kernel if appropriate)
Andy - will you be doing the backport, or are you expecting Cisco to do it and then post it here? In the past you did it and I think the expectation is that will still hold. Cisco has the requested driver version in the summary to backport.
This was the patch summary list for patches listed in comment #2:
01 enic: add support for multiple BARs
02 enic: workaround A0 erratum
03 enic: bug fix: split TSO fragments larger than 16K into
04 enic: use netdev_alloc_skb
05 enic: bug fix: protect fw call i/f with spinlock
06 enic: bug fix: included MAC drops in rx_dropped netstat
07 enic: provision for multiple Rx/Tx queues; prepare for RSS support
08 enic: bug fix: enable VLAN filtering
09 enic: changes to driver/firmware interface
10 enic: bug fix: check for zero port MTU before posting warning
11 enic: organize device initialization/deinit into separate functions
Andrius, I will pull together the backport from upstream fixes, but will appreciate review and feedback from Cisco when it is complete.
Thanks Andy - Scott definitely has OK'd to test. There is one NAPI-related patch that may be coming soon, but not sure the ETA.
Scott - anything to add here?
Yes, no problem, let us know when it's ready for review.
Let's see what the final merged version looks like and then we can check if any NAPI-related patches are required. There are some subtle differences between NAPI APIs in upstream kernel vs. 2.6.18 kernels in RHEL 5.x, so we'll be reviewing this and making sure we get the right solution for RHEL 5.x.
We need to confirm that there is commitment to test
for the resolution of this request during the RHEL 5.5 Beta
Test Phase before we can approve it for acceptance into the
RHEL 5.5 Beta Test Phase is expected to begin around February
In order to avoid any unnecessary delays, please post a
confirmation as soon as possible, including the contact
information for testing engineers.
Created attachment 370206 [details]
Scott, I have put together a patch for RHEL5 with the latest changes from upstream. It is attached here, but I will build test kernels and have them ready sometime tomorrow. It should include all the updates you requested. I'll post a link in this bug when it is ready.
My test kernels have been updated to include a patch for this bugzilla.
Please test them and report back your results.
I've down some preliminary Engineering testing with the xen and non-xen kernels and everything is working fine with enic. I haven't noticed any functional or performance issues. Thanks for merging the patches.
Per your comment #9, Cisco is committed to testing enic updates for RHEL 5.5 beta test.
The Cisco QA contact is Anthony Kent <firstname.lastname@example.org>.
Thanks. This request has been approved for update in 5.5
Thanks, Scott. I'm going to post the patch used in my test kernels for internal review tomorrow, so the more quickly you can find problems the better.
You can download this test kernel from http://people.redhat.com/dzickus/el5
Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.
~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~
RHEL 5.5 Beta has been released! There should be a fix present in this
release that addresses your request. Please test and report back results
here, by March 3rd 2010 (2010-03-03) or sooner.
Upon successful verification of this request, post your results and update
the Verified field in Bugzilla with the appropriate value.
If you encounter any issues while testing, please describe them and set
this bug into NEED_INFO. If you encounter new defects or have additional
patch(es) to request for inclusion, please clone this bug per each request
and escalate through your support representative.
This bug can be subsumed by BZ 550148 which bumps the enic version to 188.8.131.52a.
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.