Bug 519108 - [gob2] class and enum names convert incorrectly in mock / koji.
Summary: [gob2] class and enum names convert incorrectly in mock / koji.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gob2
Version: 12
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Daniel Novotny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-25 08:07 UTC by Ding-Yi Chen
Modified: 2009-12-01 04:30 UTC (History)
2 users (show)

Fixed In Version: 2.0.16-4.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-01 04:30:54 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Gob2 test package which triggers this bug. (3.24 KB, application/x-rpm)
2009-08-26 05:33 UTC, Ding-Yi Chen
no flags Details
a patch (532 bytes, patch)
2009-11-24 10:50 UTC, Daniel Novotny
no flags Details | Diff

Description Ding-Yi Chen 2009-08-25 08:07:05 UTC
Description of problem:
If build with mock/koji x86_64, some class names and enumeration names are not converted correctly, thus fail the build.

I've made a simple package which demonstrates the problem.
Gob2TestDialog.gob is converted to gob2test-dialog.c and gob2test-dialog.h

However in gob2test-dialog.c, line 80:
static void gob2test_dialog_class_init (Gob2TestDialoCClass * c) G_GNUC_UNUSED;

Where the parameter type should be Gob2TestDialogClass, not Gob2TestDialoCClass.


Strange thing is, it only happened on mock and koji build on x86_64.
In other words,
rpmbuild on F-11 i386/x86_64, OK.
rpmbuild on rawhide i386/x86_64 OK.
mock for F-11 i386/x86_64 OK.
mock for rawhide/i386, OK.
mock for rawhide, x86_64 failed.


Version-Release number of selected component (if applicable):
gob2-2.0.16-2.fc12.x86_64


How reproducible:
Always

Steps to Reproduce:
1. mock --no-cleanup-after -r fedora-devel-x86_64 gob2test-dialog-0.1-1.fc11.src.rpm
2. The build should be fail.
3. gedit /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/gob2test-dialog/gob2test-dialog.c
  
Actual results:
In gob2test-dialog.c, line 80:
the parameter type is Gob2TestDialoCClass.


Expected results:
Should be Gob2TestDialogClass

Additional info:
Not quite sure it's related or not.
If I manage to invoke glibc-2.10.1 instead of glibc-2.10.90. The build works.

Comment 1 Ding-Yi Chen 2009-08-26 05:33:18 UTC
Created attachment 358669 [details]
Gob2 test package which triggers this bug.

Comment 2 Bug Zapper 2009-11-16 11:39:53 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Daniel Novotny 2009-11-24 10:50:28 UTC
Created attachment 373382 [details]
a patch

strcpy() problem (strings may not overlap), manifests only on some systems

Comment 4 Daniel Novotny 2009-11-24 11:03:10 UTC
built in rawhide: gob2-2.0.16-3.fc13

dchen, can you please test this?
and, if you need also F12 build, please let me know

Comment 5 Ding-Yi Chen 2009-11-24 23:33:34 UTC
I've tested this, and it worked for me.
Would you mind building F-12 and F-11 as well? Thanks!

Comment 6 Daniel Novotny 2009-11-30 09:44:14 UTC
OK, will fix in F12 and F11

Comment 7 Fedora Update System 2009-11-30 10:06:43 UTC
gob2-2.0.16-4.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/gob2-2.0.16-4.fc12

Comment 8 Fedora Update System 2009-11-30 10:31:48 UTC
gob2-2.0.15-5.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/gob2-2.0.15-5.fc11

Comment 9 Fedora Update System 2009-12-01 04:15:34 UTC
gob2-2.0.15-5.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-12-01 04:30:50 UTC
gob2-2.0.16-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.