Bug 519397 - KVM: MMU: make __kvm_mmu_free_some_pages handle empty list (upstream backport)
Summary: KVM: MMU: make __kvm_mmu_free_some_pages handle empty list (upstream backport)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kvm
Version: 5.5
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Eduardo Habkost
QA Contact: Lawrence Lim
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-26 13:14 UTC by Marcelo Tosatti
Modified: 2014-03-26 01:01 UTC (History)
6 users (show)

Fixed In Version: kvm-83-108.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 07:55:40 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
KVM_MMU_make_kvm_mmu_free_some_pages_handle_empty_list.patch (947 bytes, text/plain)
2009-08-26 13:14 UTC, Marcelo Tosatti
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0271 0 normal SHIPPED_LIVE Important: kvm security, bug fix and enhancement update 2010-03-29 13:19:48 UTC

Description Marcelo Tosatti 2009-08-26 13:14:14 UTC
Created attachment 358710 [details]
KVM_MMU_make_kvm_mmu_free_some_pages_handle_empty_list.patch

commit 25ed49c02cc195d437bf5832df123fe5a8583271
Author: Izik Eidus <ieidus>
Date:   Tue Jul 28 15:26:58 2009 -0300

KVM: MMU: make __kvm_mmu_free_some_pages handle empty list

First check if the list is empty before attempting to look at list
entries.

Signed-off-by: Izik Eidus <ieidus>
Signed-off-by: Marcelo Tosatti <mtosatti>
Signed-off-by: Avi Kivity <avi>

Comment 5 lihuang 2009-08-27 15:28:43 UTC
Hi Marcelo
   Do we have test case for this fix ?

  Thanks
  Lijun Huang

Comment 6 Marcelo Tosatti 2009-08-27 16:12:32 UTC
Lijun,

Its not very trivial to reproduce / don't have a ready testcase.

Just checking it introduces no regressions should be OK.

Izik, do you agree?

Comment 7 Izik Eidus 2009-08-27 16:36:49 UTC
Yes, it would be hard to triggered
This bug fix is more against malicoues usage of kvm.

I belive checking against regressions should be enaougth..

Comment 8 lihuang 2009-08-28 02:03:37 UTC
Ok i will run the test. Thank you . Marcelo and Izik :)

Comment 12 errata-xmlrpc 2010-03-30 07:55:40 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0271.html


Note You need to log in before you can comment on or make changes to this bug.