Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://sundaram.fedorapeople.org/packages/zikula-module-feeds.spec SRPM URL: http://sundaram.fedorapeople.org/packages/zikula-module-feeds-2.1-1.fc12.src.rpm Description: RSS feeds module for Zikula Application Framework
Quick prereview: * Licensing looks good.. Probably should be GPL+ or GPLv2+ though -- there's no mention of which GPL version in this package. zikula itself says it's GPLv2+. * Same comment about source as zikula-module-pagemaster -- since the link is generated everytime a download is requested, you need to have a comment that tells how to get the source instead of the URL in the Source0 (since that won't work for subsequent downloaders). I see nothing in here that will need extra work. I'll do a full review of this tonight or tomorrow if no one else gets to it first.
Good: * rpmlint: zikula-module-feeds.noarch: W: no-documentation There is no documentation in the upstream tarball so this is fine. * Package is named according to the naming Guidelines * spec file is named after the package. * License is good. (either GPL+ or GPLv2+) * Spec file is legible. * Sources match upstream -- but see below. Also note, since the zip file is created dynamically when a download is requested, md5sums do not match. This is due to timestamps differing, not differences in the code. * Builds in koji on EPEL-5 and rawhide. * not a shared library * not content * not relocatable * Package owns all directories it creates. * macros used consistently * Permissions set correctly * rm -rf %{buildroot} run at appropriate times. NEEDSWORK: * Change the license tag to GPL+ or GPLv2+ -- the code itself only references the GPL, so it would be GPL+. However, this depends on zikula so it might be GPLv2+ like zikula. * Since the source isn't retrievable by a direct URL, you need a Source0: line with the name of the zip file and then a comment that tells where to go to get the Source. When you do these two things, I'll approve this. Optional: * No license file in the zip file. Query upstream to see if they'll include one in their next release.
http://sundaram.fedorapeople.org/packages/zikula-module-feeds.spec http://sundaram.fedorapeople.org/packages/zikula-module-feeds-2.1-2.fc12.src.rpm Will query upstream about including a copy of the license. Anything else?
Looks good. APPROVED
New Package CVS Request ======================= Package Name: zikula-module-feeds Short Description: RSS feeds module for zikula Owners: sundaram Branches: EL-5 InitialCC
CVS done.
Built in Koji: http://koji.fedoraproject.org/koji/packageinfo?packageID=9103 Closing review request.