Bug 519482 - Review Request: zikula-module-feeds - RSS feeds module for zikula
Summary: Review Request: zikula-module-feeds - RSS feeds module for zikula
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Toshio Ernie Kuratomi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-26 19:05 UTC by Rahul Sundaram
Modified: 2013-03-13 05:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-10 21:41:24 UTC
a.badger: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)

Description Rahul Sundaram 2009-08-26 19:05:38 UTC
Spec URL: http://sundaram.fedorapeople.org/packages/zikula-module-feeds.spec
SRPM URL: http://sundaram.fedorapeople.org/packages/zikula-module-feeds-2.1-1.fc12.src.rpm
Description: 
RSS feeds module for Zikula Application Framework

Comment 1 Toshio Ernie Kuratomi 2009-08-27 01:05:26 UTC
Quick prereview:
* Licensing looks good.. Probably should be GPL+ or GPLv2+ though -- there's no mention of which GPL version in this package.  zikula itself says it's GPLv2+.
* Same comment about source as zikula-module-pagemaster -- since the link is generated everytime a download is requested, you need to have a comment that tells how to get the source instead of the URL in the Source0 (since that won't work for subsequent downloaders).

I see nothing in here that will need extra work.  I'll do a full review of this tonight or tomorrow if no one else gets to it first.

Comment 2 Toshio Ernie Kuratomi 2009-08-27 19:05:52 UTC
Good:                                                            

* rpmlint:
  zikula-module-feeds.noarch: W: no-documentation

  There is no documentation in the upstream tarball so this is fine.

* Package is named according to the naming Guidelines
* spec file is named after the package.              
* License is good.  (either GPL+ or GPLv2+)          
* Spec file is legible.                              
* Sources match upstream -- but see below.  Also note, since the zip file is
  created dynamically when a download is requested, md5sums do not match.  This
  is due to timestamps differing, not differences in the code.                 
* Builds in koji on EPEL-5 and rawhide.                                        
* not a shared library                                                         
* not content
* not relocatable
* Package owns all directories it creates.
* macros used consistently
* Permissions set correctly
* rm -rf %{buildroot} run at appropriate times.

NEEDSWORK:
* Change the license tag to GPL+ or GPLv2+ -- the code itself only references
  the GPL, so it would be GPL+.  However, this depends on zikula so it might
  be GPLv2+ like zikula.
* Since the source isn't retrievable by a direct URL, you need a Source0: line
  with the name of the zip file and then a comment that tells where to go to
  get the Source.

When you do these two things, I'll approve this.

Optional:
* No license file in the zip file.  Query upstream to see if they'll include
  one in their next release.

Comment 3 Rahul Sundaram 2009-08-27 20:51:16 UTC
http://sundaram.fedorapeople.org/packages/zikula-module-feeds.spec
http://sundaram.fedorapeople.org/packages/zikula-module-feeds-2.1-2.fc12.src.rpm

Will query upstream about including a copy of the license. Anything else?

Comment 4 Toshio Ernie Kuratomi 2009-08-28 04:12:24 UTC
Looks good.

APPROVED

Comment 5 Rahul Sundaram 2009-08-28 04:23:32 UTC
New Package CVS Request
=======================
Package Name: zikula-module-feeds
Short Description: RSS feeds module for zikula 
Owners: sundaram
Branches: EL-5
InitialCC

Comment 6 Jason Tibbitts 2009-08-28 14:39:33 UTC
CVS done.

Comment 7 François Cami 2013-01-10 21:41:24 UTC
Built in Koji:
http://koji.fedoraproject.org/koji/packageinfo?packageID=9103
Closing review request.


Note You need to log in before you can comment on or make changes to this bug.