Spec URL: http://fedorapeople.org/~cweyl/review/perl-common-sense.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-common-sense-1.0-1.fc11.src.rpm Description: This module implements some sane defaults for Perl programs, as defined by two typical (or not so typical - use your common sense) specimens of Perl coders: use strict qw(vars subs); use feature qw(say state switch); no warnings; Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1645924 Additional Comment: This is a new BR of the latest JSON::XS. *rt-0.10
This has to be in the running for worst summary ever.
Upstream seems to have a sense of humor :)
please fix summary and do a scratch build in koji for f-10/11 i will meantime review deeply this package
for approval, please write better summary in spec file please see: https://fedoraproject.org/wiki/Packaging/Guidelines#summary *license ok *rpmlint ok *perl specific guidelines ok *source ok after better summary is provided, could be approved.
Here's an updated summary; though now we deviate from upstream. Spec URL: http://fedorapeople.org/~cweyl/review/perl-common-sense.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-common-sense-1.0-2.fc11.src.rpm
Approved Yes, we deviate from upstream, however, "The summary should be a short and concise description of the package." (ref: packaging guidelines). Previous summary didn't told user what to expect from package.
New Package CVS Request ======================= Package Name: perl-common-sense Short Description: Save a tree AND a kitten, use common::sense! Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
Heh. Another thing to fix :) New Package CVS Request ======================= Package Name: perl-common-sense Short Description: "Common sense" Perl defaults Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)
Can we update this pacakge to the lastest ? Also I wonder if it get pushed to F-11 updates stable via bodhi ?
Package Change Request ====================== Package Name: perl-common-sense New Branches: EL-6 Owners: lkundrak Maintainer did not respond to mail and I need this as dependency. Mail was sent at: Date: Fri, 09 Jul 2010 11:42:01 +0200 I'd be glad if maintained this though; if he ever expresses will to do so, I'll gladly hand this to him in pkgdb.
CVS done (by process-cvs-requests.py).
Package Change Request ====================== Package Name: perl-common-sense New Branches: EL-5 Owners: pghmcfc
Git done (by process-git-requests).
perl-common-sense-3.5-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-common-sense-3.5-1.el5
perl-common-sense-3.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository.