Hide Forgot
Spec URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Traits-Pluggable.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Traits-Pluggable-0.08-1.fc11.src.rpm Description: This module adds support for class precedence search for traits and some extra attributes, described below. See the MooseX::Traits manpage for more information. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1647316 Additional Comment: This package is a BR of a new BR (CatalystX::Component::Traits) of the latest Catalyst::Model::DBIC::Schema. *rt-0.10
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1647316 + rpmlint is silent for SRPM and for RPM. + source files match upstream url cf15e45f8018e929848f0b95b7e1a70acc80cb74 MooseX-Traits-Pluggable-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=89, 1 wallclock secs ( 0.04 usr 0.01 sys + 0.76 cusr 0.04 csys = 0.85 CPU) + Package perl-MooseX-Traits-Pluggable-0.08-1.fc12.noarch => Provides: perl(MooseX::Traits::Pluggable) = 0.08 Requires: perl(Carp) perl(List::MoreUtils) perl(Moose::Role) perl(Moose::Util) perl(namespace::autoclean) perl(Scalar::Util) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-MooseX-Traits-Pluggable Short Description: A pluggable extension to MooseX::Traits Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-MooseX-Traits-Pluggable New Branches: el6 Owners: iarnell tremble
Git done (by process-git-requests).