Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk-1.2.4-1.fc11.src.rpm Description: MDK stands for MIX Development Kit, and provides tools for developing and executing, in a MIX virtual machine, MIXAL programs. The MIX is Donald Knuth's mythical computer, described in the first volume of The Art of Computer Programming, which is programmed using MIXAL, the MIX assembly language. MDK includes a MIXAL assembler (mixasm) and a MIX virtual machine (mixvm) with a command line interface. In addition, a GTK+ GUI to mixvm, called gmixvm, is provided; and, in case you are an Emacs guy, you can try misc/mixvm.el, which allows running mixvm inside an Emacs GUD buffer. Using these interfaces, you can debug your MIXAL programs at source code level, and read/modify the contents of all the components of the MIX computer (including block devices, which are simultated using the file system). I'm looking for a sponsor, or if someone wishes to take over this package I'll agree on that.
I had a quick look at your package and noticed the following things that should be fixed. I'm not a sponsor, though. - according to the source files the license tag should be GPLv3+ - you can remove the following redundant dependencies: BuildRequires: glib2-devel BuildRequires: pango-devel BuildRequires: gtk2-devel - since the package ships with a GUI application, you must include a .desktop file (see https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files) - the sample files should go in a -doc subpackage
Stjepan, would you update your srpm?
Here are updated srpm and spec files based on the comment #1. Licence is changed, redundant build requires are removed, aamples are now in separate package, and finally, there is desktop file: Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk-1.2.4-2.fc11.src.rpm
Will review later.
Created attachment 361832 [details] gdb log when gmixvm consumes much CPU (and hangs) For 1.2.4-2: * License - As info files and files under doc/ are under GFDL, the license tag should be "GPLv3+ and GFDL". * %description - You don't have to duplicate the same %description into -doc subpackage. * Conditional BR (BuildRequires) - INSTALL file says: ----------------------------------------------------------------- 140 - User Option: -with-readline[=yes|no] 141 - User Option: -without-readline 142 Enables/disables the GNU Readline support for `mixvm'. If the 143 required libraries are missing (*note Requirements::) the configure 144 script with automatically disable this feature. ----------------------------------------------------------------- From configure.in, to enable readline support both "ncurses-devel" and "readline-devel" is needed for BR. Currently build.log says: ----------------------------------------------------------------- 194 checking for initscr in -lncurses... no 195 configure: WARNING: Cannot find ncurses lib ----------------------------------------------------------------- Would you enable this option? * Parallel make - Support parallel make if possible. If parallel make fails, please write a note about that on the spec file: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make * About mdk.desktop - The category "Application;" is deprecated and should be removed. - The Category line should end with semicolon, i.e. with "...Emulator;GTK;" . * Timestamps - Please consider to use ------------------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------------------ to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated from recent autotools. ! By the way, about gmixvm - On rawhide, when I try gmixvm it consumes almost 100% CPU and it becomes no responsive. gdb log attached when gmixvm hangs. Would you contact upstream?
Ok, I'll contact upstream.
(In reply to comment #5) > For 1.2.4-2: > > * License > - As info files and files under doc/ are under GFDL, the license > tag should be "GPLv3+ and GFDL". Fixed. > * %description > - You don't have to duplicate the same %description into -doc > subpackage. Fixed. > * Conditional BR (BuildRequires) > - INSTALL file says: > ----------------------------------------------------------------- > 140 - User Option: -with-readline[=yes|no] > 141 - User Option: -without-readline > 142 Enables/disables the GNU Readline support for `mixvm'. If the > 143 required libraries are missing (*note Requirements::) the > configure > 144 script with automatically disable this feature. > ----------------------------------------------------------------- > From configure.in, to enable readline support both > "ncurses-devel" and "readline-devel" is needed for BR. > Currently build.log says: > ----------------------------------------------------------------- > 194 checking for initscr in -lncurses... no > 195 configure: WARNING: Cannot find ncurses lib > ----------------------------------------------------------------- > Would you enable this option? Added in BuildRequires ncurses-devel and readline-devel > > * Parallel make > - Support parallel make if possible. If parallel make fails, please > write a note about that on the spec file: > https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make Parallel make doesn't work for this package. I added comment to make. > * About mdk.desktop > - The category "Application;" is deprecated and should be removed. > - The Category line should end with semicolon, i.e. with > "...Emulator;GTK;" . Fixed. > * Timestamps > - Please consider to use > ------------------------------------------------------------------ > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" > ------------------------------------------------------------------ > to keep timestamps on installed files as much as possible. > This method usually works for Makefiles generated from recent > autotools. Fixed. Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk-1.2.4-3.fc11.src.rpm
Now I will wait until you get some response from the upstream about gmixvm issue about consuming 100% CPU.
The problem is that gmixvm is scanning home directory (or /usr/bin directory, depending where it is started) but I was unable to find why it behaves that way. Anyway, I just sent an email to the gnu-mdk mailing list, but it seems that this list is dead for almost three years and also bug reports on sourceforge are equivalently old. We'll see if there will be any answer. In the mean time I'll try to find what's really happening.
I talked to the developer of MDK and he's unable to reproduce this error. It seems that this particular error occurs somewhere in the GTK initialization code. I'll try the package on some other Fedora or CentOS in next few days to see what will happen.
I tried to recompile, intall and run this package on CentOS and the gmixvm application come instantly. So, it seems that this is something specific to Fedora 11.
For me this occurs when Assistive technology is enabled on GNOME session. Would you check it? (please check "System" -> "Preferences" -> "Assistive Technologies")
No, I don't have enabled Assistive technologies (the checkbox is not enabled) but it still occurs.
Updated MDK to a new upstream version. I believe that the bug is now corrected because on my Fedora the gmixvm starts immediatelly. Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk-1.2.5-1.fc11.src.rpm
Well, on my system (with Assistive technology enabled) still gmixvm 1.2.5 consumes almost 100% CPU and never launches....
FWIW, for me, gmixvm doesn't show the 100% CPU issue and launches OK. I don't have Assistive Technology enabled.
Well, for unknown reason, currently I can run gmixvm on F-12 i686 system without any problem. Now I will restart this review ticket. Then for 1.2.5-1: * BR - Add "BuildRequires: intltool". http://koji.fedoraproject.org/koji/taskinfo?taskID=1806518 Otherwise okay. By the way, as this is needsponsor ticket, I want to wait for the approval of this ticket until you update bug 528108.
I added BR to the spec file. The new spec and srpm files are here: Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk-1.2.5-2.fc11.src.rpm
Okay. ------------------------------------------------------- This package (mdk) is APPROVED by mtasaka ------------------------------------------------------- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". After you request for sponsorship a mail will be sent to sponsor members automatically (which is invisible for you) which notifies that you need a sponsor. After that, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you. If you want to import this package into Fedora 11/12, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me.
I already have FAS account, the user name is sgros. And I did install client side certificate. What puzzles me now is the part "After you request for sponsorship..." because I can not find where exactly to request sponsorship?
You have requested sponsorship, on the ndisc6 review. Mamoru, ndisc6 is also ready to approve. If you want to sponsor Stjepan, be my guest.
(In reply to comment #21) > Mamoru, ndisc6 is also > ready to approve. If you want to sponsor Stjepan, be my guest. Thank you. (In reply to comment #20) > What puzzles me now is the part "After you request for sponsorship..." because > I can not find where exactly to request sponsorship? As I received the mail (on sponsors-mailing-list), I guess you did the proper procedure. Now I am sponsoring you. Please follow "Join" wiki again.
New Package CVS Request ======================= Package Name: mdk Short Description: GNU MIX Development Kit Owners: sgros Branches: F-12 InitialCC: sgros
CVS done.
Ok, I imported files into CVS for devel and F-12 branches. Build in koji was also successful. I suppose this bug entry could be now closed?
Did you file an update for F-12 in bodhi? If not, when you do, you can put this BZ # in the update, and have it close the BZ when the package is pushed to stable.
mdk-1.2.5-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mdk-1.2.5-2.fc12
Closing.
mdk-1.2.5-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.