Bug 520714 - Review Request: perl-CGI-Application-Plugin-DBIC-Schema - Easy DBIx::Class access from CGI::Application
Summary: Review Request: perl-CGI-Application-Plugin-DBIC-Schema - Easy DBIx::Class ac...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-01 21:40 UTC by Emmanuel Seyman
Modified: 2009-09-15 07:35 UTC (History)
3 users (show)

Fixed In Version: 0.2-1.fc11
Clone Of:
Environment:
Last Closed: 2009-09-15 07:35:53 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2009-09-01 21:40:18 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-DBIC-Schema/perl-CGI-Application-Plugin-DBIC-Schema.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-DBIC-Schema/perl-CGI-Application-Plugin-DBIC-Schema-0.2-1.fc11.src.rpm
Description:
CGI::Application::Plugin::DBIC::Schema adds easy access to a
DBIx::Class::Schema to your Titanium or CGI::Application modules. Lazy
loading is used to prevent a database connection from being made if the
schema method is not called during the request. In other words, the
database connection is not created until it is actually needed.

Comment 1 Parag AN(पराग) 2009-09-02 06:43:03 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1649241
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
ab4111ee9a6058b5afecd43e2e3969556db742a7  CGI-Application-Plugin-DBIC-Schema-0.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=1,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.17 cusr  0.02 csys =  0.22 CPU)
+ Package perl-CGI-Application-Plugin-DBIC-Schema-0.2-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::DBIC::Schema) = 0.2
Requires: perl(Carp) perl(Exporter) perl(strict) perl(vars)

+ Not a GUI application

APPROVED.

Comment 2 Emmanuel Seyman 2009-09-03 09:35:08 UTC
Strange, I never received any mail from this bug.
Thanks for the review, Parag. Requesting CVS.

New Package CVS Request
=======================
Package Name: perl-CGI-Application-Plugin-DBIC-Schema
Short Description: Easy DBIx::Class access from CGI::Application
Owners: eseyman
Branches: F-10 F-11 F-12
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-09-04 02:14:31 UTC
cvs done.

Comment 4 Fedora Update System 2009-09-04 09:11:24 UTC
perl-CGI-Application-Plugin-DBIC-Schema-0.2-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-DBIC-Schema-0.2-1.fc11

Comment 5 Fedora Update System 2009-09-06 20:43:03 UTC
perl-CGI-Application-Plugin-DBIC-Schema-0.2-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-DBIC-Schema'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9365

Comment 6 Fedora Update System 2009-09-15 07:35:48 UTC
perl-CGI-Application-Plugin-DBIC-Schema-0.2-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.