Description of problem:

Reviewed psacct's initscript and found few minor caveats or incompatibilities with https://fedoraproject.org/wiki/FCNewInit/Initscripts

Version-Release number of selected component (if applicable):

psacct-6.3.2-53.fc11.x86_64

Actual results:

---[1]---------------------------------------------------------
"""
  *)
        # do not advertise unreasonable commands that there is no reason
        # to use with this device
        echo $"Usage: $0 {start|stop|status|restart|reload}"
        exit 1
"""
Should be better: exit 2, or exit 3
---[2]---------------------------------------------------------
"""
start()
        if [ -r $ACCTFILE ]; then
            ...
        else
            exit 1
        fi
"""
Should be better: exit 4 (aka: 4 user had insufficient privilege)
---[3]---------------------------------------------------------
"""
start()
            if [ $RETVAL -eq 0 ]; then
                ...
            else
                exit 3
            fi
"""
Should be better: exit 7 (aka: 7 program is not running)
---[4]---------------------------------------------------------
"""
stop()
        if [ $RETVAL -eq 0 ]; then
            ...
            exit 3
        else
            exit 0
        fi
"""
Should be better: exit 0 (or no exit at all) and exit 1 (on the second "exit" line), so, stopping service ends with exit code == 0 in case of success.