Update arcmsr driver to better match upstream
Hi Tomas, I plan to do that in the near future after I finish the projects. Are there any urgent feedbacks from customers?
(In reply to comment #1) > Are there any urgent feedbacks from customers? Hi Nick, I'm not aware of any urgent reports. For the latest sources look here -> http://people.redhat.com/dzickus/el5/
Created attachment 361642 [details] fix missing attr This patch makes adjust_queue_depth work by adding the missing "struct device_attribute *attr" to the function parameters.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
(In reply to comment #1) > Hi Tomas, > I plan to do that in the near future after I finish the projects. Hi Nick, to be accepted I need your patch soon. Thanks, Tomas
Hi Tomas, I though you have patched it. What should I do? Copy the patch and then paste it as a comment? Thanks,
Hi Tomas, I am completely confused by the version. I will check it out particularly.
(In reply to comment #6) > Hi Tomas, > I though you have patched it. > What should I do? Copy the patch and then paste it as a comment? No, but if you want add some other patch (I don't know what is useful) then post it here. It is also OK if you don't want add anything.
Hi Tom, One more question, what is the next kernel versions for RHEL4 and RHEL5? That will affect the range of the patch. Thank you,
(In reply to comment #9) > Hi Tom, > One more question, what is the next kernel versions for RHEL4 and RHEL5? > That will affect the range of the patch. > Thank you, Hi Nick, the kernel in RHEL5 is a heavily patched 2.6.18 kernel (RHEL4 - 2.6.9). We don't rebase the kernel between minor releases. For the latest sources look at comment#2
@nick.cheng We need to confirm that there is commitment to test for the resolution of this request during the RHEL 5.5 test phase, if it is accepted into the release. Please post a confirmation before Oct 23rd, 2009, including the contact information for testing engineers.
Chris, I am testing the driver. I will report the result before Oct 23rd, 2009 as you wish.
(In reply to comment #13) > Chris, > I am testing the driver. > I will report the result before Oct 23rd, 2009 as you wish. Nick, it's not necessary to _test_ this before Oct 23rd. We just needed your _confirmation_ before that date to make sure the fix will be tested some day. We will need your test feedback when the rhel5.5 build is ready which is around 2010-01-21. Thanks.
Chris, OK. I got it. But I have patched the source code and test it on my site. So far, it is OK.
Nick, in the initial version of the driver the arcmsr_adjust_disk_queue_depth was part of arcmsr_scsi_host_template : static struct scsi_host_template arcmsr_scsi_host_template = { ... .bios_param = arcmsr_bios_param, .change_queue_depth = arcmsr_adjust_disk_queue_depth, .can_queue = ARCMSR_MAX_OUTSTANDING_CMD, Can you remember what was the reason for removing it from here (in bz363961) and adding it to ? .sdev_attrs = arcmsr_scsi_device_attr, Has that change ever been posted upstream ?
Hi Tomas, I remember because Redhat kernel at that time did not support it in scsi_host_template, I move it to .sdev_attrs. It has no need to upstream it because the original is synchronous with kernel source. FYI,
Thanks Nick. Posted today on rhkl.
in kernel-2.6.18-173.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please do NOT transition this bugzilla state to VERIFIED until our QE team has sent specific instructions indicating when to do so. However feel free to provide a comment indicating that this fix has been verified.
Sorry to ask. It is kernel-2.6.18-173.el5 or kernel-2.6.18-172.el5. I saw it is all about kernel-2.6.18-172.el5.
(In reply to comment #21) > Sorry to ask. > It is kernel-2.6.18-173.el5 or kernel-2.6.18-172.el5. > I saw it is all about kernel-2.6.18-172.el5. Nick, sorry for being late I missed you latest comment. It doesn't matter if the patch is also in -172. Take please the latest kernel and test it. You should verify that the driver and the patch works ok.
~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~ RHEL 5.5 Beta has been released! There should be a fix present in this release that addresses your request. Please test and report back results here, by March 3rd 2010 (2010-03-03) or sooner. Upon successful verification of this request, post your results and update the Verified field in Bugzilla with the appropriate value. If you encounter any issues while testing, please describe them and set this bug into NEED_INFO. If you encounter new defects or have additional patch(es) to request for inclusion, please clone this bug per each request and escalate through your support representative.
Chris, what info do you need from me?
@Nick, We would greatly appreciate some testing feedback for this request. Please confirm that the issue has been resolved in the latest RHEL 5.5 Beta bits as soon as possible. Thank you
OK, I got it. I will test it ASAP.
@Nick, any updates?
Chris, It is still running so far so good.
Good news! Let us know if any issues are discovered then.
Guys, After two-week testing, it is good so far. FYI,
@Areca Please do not close bugs which are part of a release. Thank you.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0178.html