First pass at pki-selinux package for Fedora
You forgot to attach spec- and srpm-file.
Hi Peter, the spec, source tarball and src.rpm files can be found here: http://people.redhat.com/kwright/pki-selinux/
Please use standard naming for the summaries of the review requests: "Review Request: foo - an app that does bar"
This review ticket is assigned to kwright, but according to the account system that user is not a packager and so cannot do reviews.
I ran a quick rpmlint on the binary rpm after building it on f12 aplha. rpmlint on SPEC - silent rpmlint on SRPM - silent rpmlint on binary RPM: [build@f12-alpha noarch]$ rpmlint -ivv pki-selinux-1.3.0-1.fc12.noarch.rpm pki-selinux.noarch: I: checking pki-selinux.noarch: W: dangerous-command-in-%pre cp pki-selinux.noarch: W: dangerous-command-in-%post rm pki-selinux.noarch: W: dangerous-command-in-%preun cp pki-selinux.noarch: W: dangerous-command-in-%postun rm 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
The description of this package is as follows: Selinux policies for the Pubic Key Infrastructure (PKI) components.
Note on Warnings above: The pre, post, preun and postun scripts have been carefully checked to confirm that the correct file is copied and removed. In fact, the file that is created in %pre is deleted in %post, and the file that is created in %preun is deleted in %postun. These scripts are in fact identical to scripts already accepted in Fedora for the IPA spec file.
Updated spec file and src rpm: Spec URL: http://people.redhat.com/kwright/pki-setup/pki-selinux.spec SRPM URL: http://people.redhat.com/kwright/pki-setup/pki-selinux-1.3.0-1.fc11.src.rpm
* Tue Nov 17 2009 Kevin Wright <kwright> 1.3.0-2 - Bugzilla Bug #521255 - Packaging for Fedora Dogtag PKI - Remove un-necessary installation steps. Spec URL: http://people.redhat.com/kwright/pki-setup/pki-selinux.spec SRPM URL: http://people.redhat.com/kwright/pki-setup/pki-selinux-1.3.0-2.fc11.src.rpm rpmlint SRPMS/pki-selinux-1.3.0-2.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
srpm gives a 404 error.
fixed the urls: Spec URL: http://people.redhat.com/kwright/pki-selinux/pki-selinux.spec SRPM URL: http://people.redhat.com/kwright/pki-selinux/pki-selinux-1.3.0-2.fc11.src.rpm
1) why is it necessary to list explicitly selinux-policy-devel with versions for f9/f10/f11? 2) why not to choose following as Group? Group: System Environment/Base 3)Please add comments in SPEC on why rpmlint messages for pre/post/preun/postun is valid?
Regarding issues with this package: * "BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)" is provided because this package must also be made into an EPEL package * Although we create the "}%{_datadir}/selinux/modules/" directory, we do not own the "modules" directory because ownership of this specific directory will be a part of one of Dan Walsh's SELinux packages (Ade can answer this better than I if needed) * Although the RPM contains four warnings, these are expected, and are inherited from other SELinux packages (SELinux can answer this better than I if needed)
* Mon Dec 14 2009 Matthew Harmsen <mharmsen> 1.3.0-4 - Removed 'with exceptions' from License * Mon Dec 7 2009 Matthew Harmsen <mharmsen> 1.3.0-3 - Bugzilla Bug #528556 - policycoreutils-python (semanage) prerequisite missing from rpm - Removed "conditional" support for Fedora 9 Updated spec file and src rpm: Spec URL: http://people.redhat.com/kwright/pki-setup/pki-selinux.spec SRPM URL: http://people.redhat.com/kwright/pki-setup/pki-selinux-1.3.0-4.fc11.src.rpm
unable to download srpm/spec.
corrected the url for the spec file and srpm: Spec URL: http://people.redhat.com/kwright/pki-selinux/pki-selinux.spec SRPM URL: http://people.redhat.com/kwright/pki-selinux/pki-selinux-1.3.0-4.fc11.src.rpm
Hi Dennis, Can you review this package or I can review it if you don't mind?
%{?fc10:Requires: selinux-policy-targeted >= 3.5.13-41} %{?fc11:Requires: selinux-policy-targeted >= 3.6.3-10} %{?fc10:BuildRequires: selinux-policy-devel >= 3.5.13-41} %{?fc11:BuildRequires: selinux-policy-devel >= 3.6.3-10} need to go they will only create confusion and are already irrelevant f-12 and rawhide are not covered and Fedora 10 is EOL having the generic Requires and BuildRequires are sufficient.
------------------------------- Updated spec file and src rpm to remove obsolete Requires and Build Requires: Spec URL: http://people.redhat.com/kwright/pki-selinux/pki-selinux.spec SRPM URL: http://people.redhat.com/kwright/pki-selinux/pki-selinux-1.3.0-5.fc11.src.rpm
rpmlint /var/lib/mock/fedora-12-x86_64/result/ pki-selinux.noarch: W: spelling-error-in-summary en_US Dogtag pki-selinux.noarch: W: dangerous-command-in-%pre cp pki-selinux.noarch: W: dangerous-command-in-%post rm pki-selinux.noarch: W: dangerous-command-in-%preun cp pki-selinux.noarch: W: dangerous-command-in-%postun rm pki-selinux.src: W: spelling-error-in-summary en_US Dogtag 2 packages and 0 specfiles checked; 0 errors, 6 warnings. sha256sum pki-selinux-1.3.0.tar.gz fedora/SOURCES/pki-selinux-1.3.0.tar.gz 899833072eb20d9edc8e46a4f166b67be816cf335a04cfdc84c1f362a2ea1d3b pki-selinux-1.3.0.tar.gz 899833072eb20d9edc8e46a4f166b67be816cf335a04cfdc84c1f362a2ea1d3b fedora/SOURCES/pki-selinux-1.3.0.tar.gz spec is clean Approved
New Package CVS Request ======================= Package Name: pki-selinux Short Description: Dogtag Security Enhanced Linux Owners: kwright Branches: F-11, F-12, EL-5 InitialCC: ausil
CVS done (by process-cvs-requests.py)
pki-selinux-1.3.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pki-selinux-1.3.1-1.fc12
pki-selinux-1.3.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pki-selinux-1.3.1-1.fc11
pki-selinux-1.3.1-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/pki-selinux-1.3.1-1.el5
pki-selinux-1.3.1-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-selinux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0064
pki-selinux-1.3.1-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-selinux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0509
pki-selinux-1.3.1-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-selinux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0522
pki-selinux-1.3.2-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pki-selinux-1.3.2-1.fc11
pki-selinux-1.3.2-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pki-selinux-1.3.2-1.fc12
pki-selinux-1.3.2-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-selinux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0902
pki-selinux-1.3.2-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-selinux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0949
pki-selinux-1.3.3-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pki-selinux-1.3.3-1.fc11
pki-selinux-1.3.3-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/pki-selinux-1.3.3-1.el5
pki-selinux-1.3.3-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pki-selinux-1.3.3-1.fc12
pki-selinux-1.3.3-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-selinux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1023
pki-selinux-1.3.3-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-selinux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1047
pki-selinux-1.3.3-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-selinux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0128
pki-selinux-1.3.3-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
pki-selinux-1.3.3-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
pki-selinux-1.3.3-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.